Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JGD2011 support to formats supporting WGS 84 #701

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Conversation

ciscorn
Copy link
Member

@ciscorn ciscorn commented Feb 1, 2025

Resolves #700

@ciscorn ciscorn requested a review from nokonoko1203 February 1, 2025 03:27
Copy link

coderabbitai bot commented Feb 1, 2025

Walkthrough

このプルリクエストは、JGD2011地理座標系と標高に関する設定ファイルとドキュメンテーションの更新を行っています。主にsettings.tsファイルにおいて、さまざまなファイルタイプ(GPKG、GeoJSON、Cesium Tiles、KML、Shapefile)のEPSGオプションに新しいラベルと座標系オプションを追加しました。また、vshift.rsファイルでは、Jgd2011ToWgs84構造体のドキュメンテーションコメントの小さな書式修正を行っています。

Changes

ファイル 変更概要
app/src/lib/settings.ts - filetypeOptionsオブジェクトのEPSGオプションを更新
- WGS 84とJGD2011の座標系ラベルに楕円体高と標高の情報を追加
nusamai-projection/src/vshift.rs - Jgd2011ToWgs84構造体のドキュメンテーションコメントを微修正

Assessment against linked issues

目的 対応状況 説明
JGD2011地理 + 標高 (EPSG:6697) に対応する [#700]

Poem

🌍 座標の旅、新たな道
標高と楕円体、データの歌
JGD2011、その輝き
コードは進化し、世界を描く
🗺️ マッピングの魔法、ここにあり


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 15be0e7 and 95beabf.

📒 Files selected for processing (2)
  • app/src/lib/settings.ts (4 hunks)
  • nusamai-projection/src/vshift.rs (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • nusamai-projection/src/vshift.rs
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: build
  • GitHub Check: test
  • GitHub Check: test
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (5)
app/src/lib/settings.ts (5)

9-10: GeoPackageフォーマットのEPSGオプションの更新が適切です!

WGS 84の楕円体高の明示と、JGD2011 + 標高オプションの追加により、座標系の選択がより明確になりました。


49-52: GeoJSONフォーマットのEPSGオプションの更新が適切です!

GeoPackageフォーマットと同様の座標系オプションを提供することで、フォーマット間の一貫性が保たれています。


59-59: "特殊:"プレフィックスの意図を確認してください。

3D Tilesフォーマットで、JGD2011オプションに"特殊:"というプレフィックスが追加されていますが、この特別な扱いが必要な理由についてドキュメントに説明を追加することを推奨します。


86-87: Shapefileフォーマットのオプション追加が適切です!

他のフォーマットと同様に、WGS 84の楕円体高の明示とJGD2011 + 標高オプションの追加が適切に行われています。


75-75: ⚠️ Potential issue

KMLフォーマットでWGS 84サポートが削除されている理由を確認してください。

KMLフォーマットでWGS 84のサポートが削除され、JGD2011 + 標高のみがサポートされるように変更されています。この変更は既存のユーザーに影響を与える可能性があります。この変更が意図的なものか確認が必要です。

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ciscorn ciscorn self-assigned this Feb 1, 2025
@ciscorn ciscorn added the enhancement New feature or request label Feb 1, 2025
Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files
Components Coverage Δ
GUI 0.00% <ø> (ø)
Backend 74.64% <ø> (ø)
Libraries 85.87% <ø> (ø)

📢 Thoughts on this report? Let us know!

@nokonoko1203
Copy link
Collaborator

lgtm!

@nokonoko1203 nokonoko1203 merged commit ae13509 into main Feb 1, 2025
10 checks passed
@nokonoko1203 nokonoko1203 deleted the jgd2011output branch February 1, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JGD2011地理 + 標高 (&#x60;EPSG:6697&#x60;) に対応する
2 participants