-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve Full Trajectory Information in AnalysisBase #4892
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4892 +/- ##
===========================================
- Coverage 93.65% 93.63% -0.03%
===========================================
Files 177 189 +12
Lines 21795 22863 +1068
Branches 3067 3067
===========================================
+ Hits 20413 21408 +995
- Misses 931 1004 +73
Partials 451 451 ☔ View full report in Codecov by Sentry. |
Hello @yuxuanzhuang! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2025-01-14 18:49:12 UTC |
I’m not certain that |
Fixes #4891
Changes made in this Pull Request:
self._global_slicer
to retrieve global details such as the total number of frames.self._global_frame_index
for_single_frame
to track the global frame index for each framePR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4892.org.readthedocs.build/en/4892/