Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering by GameMode (& don't spam BeatSaver) #6

Open
Luux opened this issue May 22, 2020 · 2 comments
Open

Filtering by GameMode (& don't spam BeatSaver) #6

Luux opened this issue May 22, 2020 · 2 comments

Comments

@Luux
Copy link
Owner

Luux commented May 22, 2020

89219da contains an experimental first approach of filtering maps by game mode.
This allows searching specifically for OneSaber or 360° maps for example. However, this first implementation has flaws which is why it won't go into master right now: a) it's slow, b) it spams the BeatSaver API with hundreds of requests to find a few songs, since OneSaber maps are quite rare. This is not optimal and cannot be changed directly right now because of how the BeatSaver API works.

However, I could download a regularly updated scrape of the BeatSaver data regularly and perform the search locally on that copy. Daily updated scrapes are already available at https://github.com/andruzzzhka/BeatSaberScrappedData
The problem is that at the moment, the scraped data from BeatSaver doesn't contain the much needed characteristic infos which is where the game mode information lies. If andruzzzhka includes this information in the future, that would be the solution as long as the BeatSaver API is as it is.
kinsi55/BeatSaberScrappedData#3

@Luux Luux changed the title Filtering by GameMode Filtering by GameMode (& don't spam BeatSaver) May 22, 2020
@Luux
Copy link
Owner Author

Luux commented May 23, 2020

Update: The characteristics are now present in the scraped data. Filtering by gamemode will be available soon!

@Luux
Copy link
Owner Author

Luux commented Jan 27, 2021

For GameMode filtering, some algorithmic changes for ARBSMapDo have to be made. However, the cache is implemented now and should speed up ARBSMapDo significantly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant