Make Arguments::is_filtered_out public
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some test binaries want to offer extensions to the `libtest` interface that operate on a set of tests. For example, a test binary may want to allow the user to request the set of environmental dependencies (e.g., external artifacts to download) for running a set of tests. In such cases, it is desirable to allow the user to specify test filters using the same interface for filtering tests to run. To this end, expose the existing `Arguments::is_filtered_out` function publicly. This allows the test binary to apply the same filtering logic without having to call and somehow extract the results from `run`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some test binaries want to offer extensions to the
libtestinterface that operate on a set of tests. For example, a test binary may want to allow the user to request the set of environmental dependencies (e.g., external artifacts to download) for running a set of tests. In such cases, it is desirable to allow the user to specify test filters using the same interface for filtering tests to run.To this end, expose the existing
Arguments::is_filtered_outfunction publicly. This allows the test binary to apply the same filtering logic without having to call and somehow extract the results fromrun.Fixes #37.