Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retrieval of observation and action spaces when using wrappers #129

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

LucasAlegre
Copy link
Owner

The observation and action spaces should be retrieved without the .unwrapped, so that the agent can get the correct spaces when a wrapper is being used.

Thanks @wilrop for spotting this!

@LucasAlegre LucasAlegre added the bug Something isn't working label Dec 4, 2024
@LucasAlegre LucasAlegre requested a review from ffelten December 4, 2024 14:04
@LucasAlegre LucasAlegre self-assigned this Dec 4, 2024
Copy link
Collaborator

@ffelten ffelten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LucasAlegre LucasAlegre merged commit 92572aa into main Dec 4, 2024
4 checks passed
@LucasAlegre LucasAlegre deleted the fix-unwrapped branch December 4, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants