Compare Node version against nvmrc file, show ⚠️ on mismatch (#19)

LucaScorpion · Jul 26, 2023 · 52eb2d8 · 52eb2d8
1 parent 581fd02
commit 52eb2d8
Show file tree

Hide file tree

Showing 11 changed files with 72 additions and 16 deletions.
diff --git a/internal/semver.go b/internal/semver.go
@@ -0,0 +1,30 @@
+package internal
+
+import "strings"
+
+func SemVerMatches(current, expected string) bool {
+	expected = strings.TrimSpace(expected)
+	if expected == "" {
+		return true
+	}
+
+	// Strip a leading 'v' from both versions.
+	if current[0] == 'v' {
+		current = current[1:]
+	}
+	if expected[0] == 'v' {
+		expected = expected[1:]
+	}
+
+	fullVersionParts := strings.Split(current, ".")
+	checkParts := strings.Split(expected, ".")
+
+	// Check if all the parts of the expected version match the current version.
+	for i, part := range checkParts {
+		if i >= len(fullVersionParts) || part != fullVersionParts[i] {
+			return false
+		}
+	}
+
+	return true
+}
diff --git a/internal/versions/docker.go b/internal/versions/docker.go
@@ -16,7 +16,7 @@ var Docker = section{
 	},
 
 	command: []string{"docker", "-v"},
-	versionFunc: func(output string) string {
+	versionFn: func(output string) string {
 		/*
 			Example:
 			Docker version 23.0.1, build a5ee5b1dfc

diff --git a/internal/versions/dotnet.go b/internal/versions/dotnet.go
@@ -20,7 +20,7 @@ var Dotnet = section{
 	},
 
 	command: []string{"dotnet", "--version"},
-	versionFunc: func(output string) string {
+	versionFn: func(output string) string {
 		/*
 			Example:
 			6.0.114

diff --git a/internal/versions/golang.go b/internal/versions/golang.go
@@ -17,7 +17,7 @@ var Go = section{
 	},
 
 	command: []string{"go", "version"},
-	versionFunc: func(output string) string {
+	versionFn: func(output string) string {
 		/*
 			Example:
 			go version go1.20.2 linux/amd64

diff --git a/internal/versions/java.go b/internal/versions/java.go
@@ -23,7 +23,7 @@ var Java = section{
 	},
 
 	command: []string{"java", "--version"},
-	versionFunc: func(output string) string {
+	versionFn: func(output string) string {
 		/*
 			Example:
 			openjdk 19.0.2 2023-01-17

diff --git a/internal/versions/node.go b/internal/versions/node.go
@@ -1,7 +1,9 @@
 package versions
 
 import (
+	"gokart-prompt/internal"
 	"gokart-prompt/internal/ansi"
+	"os"
 )
 
 var Node = section{
@@ -11,18 +13,33 @@ var Node = section{
 	upsearchFiles: []string{
 		"node_modules",
 		"package.json",
+		".nvmrc",
 	},
 	wdFiles: []string{
 		"*.js",
 		"*.ts",
 	},
 
 	command: []string{"node", "-v"},
-	versionFunc: func(output string) string {
+	versionFn: func(output string) string {
 		/*
 			Example:
 			v19.1.0
 		*/
 		return output
 	},
+
+	expectedVersionFn: func() string {
+		file, found := internal.UpsearchWd([]string{".nvmrc"})
+		if !found {
+			return ""
+		}
+
+		bytes, err := os.ReadFile(file)
+		if err != nil {
+			return ""
+		}
+
+		return string(bytes)
+	},
 }
diff --git a/internal/versions/php.go b/internal/versions/php.go
@@ -17,7 +17,7 @@ var Php = section{
 	},
 
 	command: []string{"php", "-v"},
-	versionFunc: func(output string) string {
+	versionFn: func(output string) string {
 		/*
 			Example:
 			PHP 8.2.4 (cli) (built: Mar 15 2023 15:27:52) (NTS)

diff --git a/internal/versions/python.go b/internal/versions/python.go
@@ -19,7 +19,7 @@ var Python = section{
 	},
 
 	command: []string{"python", "--version"},
-	versionFunc: func(output string) string {
+	versionFn: func(output string) string {
 		/*
 			Example:
 			Python 3.10.10

diff --git a/internal/versions/ruby.go b/internal/versions/ruby.go
@@ -18,7 +18,7 @@ var Ruby = section{
 	},
 
 	command: []string{"ruby", "-v"},
-	versionFunc: func(output string) string {
+	versionFn: func(output string) string {
 		/*
 			Example:
 			ruby 3.0.5p211 (2022-11-24 revision ba5cf0f7c5) [x86_64-linux]

diff --git a/internal/versions/rust.go b/internal/versions/rust.go
@@ -17,7 +17,7 @@ var Rust = section{
 	},
 
 	command: []string{"rustc", "--version"},
-	versionFunc: func(output string) string {
+	versionFn: func(output string) string {
 		/*
 			Example:
 			rustc 1.69.0 (84c898d65 2023-04-16) (Arch Linux rust 1:1.69.0-2)

diff --git a/internal/versions/section.go b/internal/versions/section.go
@@ -7,12 +7,13 @@ import (
 )
 
 type section struct {
-	symbol        string
-	color         ansi.ColorCode
-	upsearchFiles []string
-	wdFiles       []string
-	command       []string
-	versionFunc   func(output string) string
+	symbol            string
+	color             ansi.ColorCode
+	upsearchFiles     []string
+	wdFiles           []string
+	command           []string
+	versionFn         func(output string) string
+	expectedVersionFn func() string
 }
 
 func (s section) version(wdFiles []string) string {
@@ -21,7 +22,15 @@ func (s section) version(wdFiles []string) string {
 	}
 
 	if output, ok := internal.Command(s.command[0], s.command[1:]...); ok {
-		return ansi.Color(s.color, s.symbol+" "+s.versionFunc(output))
+		curVersion := s.versionFn(output)
+		str := s.symbol + " " + curVersion
+
+		// Check if we know the expected version, and if that matches the found version.
+		if s.expectedVersionFn != nil && !internal.SemVerMatches(curVersion, s.expectedVersionFn()) {
+			str += " ⚠️ "
+		}
+
+		return ansi.Color(s.color, str)
 	}
 
 	return ""