Make the channels less fail-prone by initialising them once the subsc…

…ription succeeds and ensuring they always close in case of an error to prevent a deadlock

streaming/client.go

@@ -111,17 +111,12 @@ func ReadStream[T any](connection *tls.Conn, reads chan<- T) (err error) {
 		var x T
 
 		if err := dec.Decode(&x); err != nil && err != io.EOF {
-			return err
+			break
 		}
 
-		select {
-		case reads <- x:
-		default:
-			return nil
-		}
+		reads <- x
 	}
 
 	close(reads)
-
 	return nil
 }

streaming/market.go

@@ -116,13 +116,11 @@ func (client *StreamingClient) SubscribeToMarkets(marketFilter MarketFilter, mar
 		Clk:                 client.Clk,
 	}
 
-	marketChanges := make(chan MarketChangeMessage)
-
 	if err := client.Write(ms, true); err != nil {
-		close(marketChanges)
-		return marketChanges, err
+		return nil, err
 	}
 
+	marketChanges := make(chan MarketChangeMessage)
 	go ReadStream(client.Connection, marketChanges)
 
 	return marketChanges, nil

streaming/order.go

@@ -93,13 +93,11 @@ func (client *StreamingClient) SubscribeToOrders(orderFilter OrderFilter) (chan
 		Clk:                 client.Clk,
 	}
 
-	orderChanges := make(chan OrderChangeMessage)
-
 	if err := client.Write(ms, true); err != nil {
-		close(orderChanges)
-		return orderChanges, err
+		return nil, err
 	}
 
+	orderChanges := make(chan OrderChangeMessage)
 	go ReadStream(client.Connection, orderChanges)
 
 	return orderChanges, nil