-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add serde support for tl_types. #277
Conversation
Related issue #276 |
Whoops, generated code seems encount some issue. |
Can you revert the formatting change to the .toml files out of this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand why so many crates need the serde dependency. Shouldn't it only be grammers-tl-types
?
Also, please make it optional. I want to continue offering the crates with serde off by default.
I tried to add serde code only in Then I add my fork of I not formillar with build system, but I am looking into it.
Sure, I will write cfg(feature="serde") in |
Behavior nowUser can fetch any raw struct (defined by FlawStructure in Example |
We need more test and docs about this new feature. |
First PRs require me to click the Approve button every time to have CI run, so it might take a while until I realize I had to click it again. |
We have some I don't know whether Plan 1. If Plan 2. Maybe we could add a type alia in generated file to distinguish bytes and vector in generate logic. Plan 3. We could use 3-rd party dependence like Plan 4. Leave this as a flaw, do nothing about it. Anyway, I fix the broken test, it is because the blank space in generated code. And revert to the commit that no new duplicate test in |
I think this is fine. Needing to serialize types like that seems extremely unlikely. As long as it works, even if it's inefficient, I think it's fine. |
Add two lines for each entrance in generated.rs
(Did I miss for other things?)
Pass all tests in crate
grammers-tl-types