Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Client.next_update signature #254

Merged
merged 5 commits into from
Aug 11, 2024
Merged

Optimize Client.next_update signature #254

merged 5 commits into from
Aug 11, 2024

Conversation

dimentyy
Copy link
Contributor

This method does not return Ok(None), so Option is useless

@Lonami Lonami merged commit b49bb9d into Lonami:master Aug 11, 2024
1 check passed
@Lonami
Copy link
Owner

Lonami commented Aug 11, 2024

Thanks. I probably made it Option to handle the client being disconmected, but indeed that should probably be Err, not None.

@Lonami
Copy link
Owner

Lonami commented Aug 29, 2024

Actually maybe the reason was parity with Stream. Not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimentyy @Lonami