Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove article_exclude_reason column #17

Merged
merged 5 commits into from
Dec 4, 2023

Conversation

duynguyen158
Copy link
Contributor

Description

Removes the article_exclude_reason from the Page table in order to let training job business logic handle which article to not recommend. To aid this, creates two new columns in the Article table: language and is_in_house_content.

Terraform

No changes except for resources forced to be replaced.

Alembic

New revision was generated. Refer to the alembic directory.

Testing

Two tests for the deleted column were removed. All tests passed.

@duynguyen158 duynguyen158 merged commit cd6a12e into dev Dec 4, 2023
1 check passed
@duynguyen158 duynguyen158 deleted the remove-article-exclude-reason branch December 4, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant