Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE_REQUEST] Move conf.yml to its own folder #1322

Closed
BlindBadgerStudios opened this issue Sep 20, 2023 · 8 comments
Closed

[FEATURE_REQUEST] Move conf.yml to its own folder #1322

BlindBadgerStudios opened this issue Sep 20, 2023 · 8 comments
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change

Comments

@BlindBadgerStudios
Copy link

Is your feature request related to a problem? If so, please describe.

Not related to a problem per-se, but related to the inability to map to a NFS volume (which must be a directory). The instructions map a specific file, which is not an option when using NFS volumes in docker compose. Moving it to a separate directory allows that directory to be mapped just for the conf file, rather than risking having to copy all the other files as well.

Describe the solution you'd like

Code updated to look for and leverage a conf.yml file in a separate directory (Ex. /app/public/conf)

Priority

Low (Nice-to-have)

Is this something you would be keen to implement

None

@BlindBadgerStudios BlindBadgerStudios added the 🦄 Feature Request [ISSUE] Suggestion for new feature, update or change label Sep 20, 2023
@liss-bot
Copy link
Collaborator

If you're enjoying Dashy, consider dropping us a ⭐
🤖 I'm a bot, and this message was automated

@joshbuker
Copy link

This exact problem has been frustrating with trying to use Dashy in a docker swarm setup. 😅

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Nov 11, 2023
@joshbuker
Copy link

Related: #693

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Nov 12, 2023
@bajo
Copy link

bajo commented Nov 19, 2023

I opened PR #1393 to address this feature request. Feel free to test an report back any issues in the PR.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Nov 19, 2023
@jordiboehme
Copy link

This issue is also preventing me from using dashy.

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Dec 31, 2023
@Glitch3dPenguin
Copy link
Contributor

I would also like to see this implemented for in-place upgrades.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Mar 19, 2024
@Soccerbeats
Copy link

@bajo Seems to have a solution that looks like it would be easily added.

I opened PR #1393 to address this feature request. Feel free to test an report back any issues in the PR.

The main reason for me that this would be helpful is in docker, you can create a volume that prevents the conf.yml from being updated when I pull for and update to the app. Hence, you would not need to do a backup/restore every time you update Dashy.
This would be AWESOME! :)

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Mar 20, 2024
@CrazyWolf13
Copy link
Collaborator

Hi
This should now be fixed within the new V3 release of dashy, take a look here #1537 and here #1529

Keep in mind V3 has breaking changes, update the volumes and the port accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change
Projects
None yet
Development

No branches or pull requests

8 participants