Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Popup modal doesn't work in multipage mode #1274

Closed
5 tasks done
ThinkSalat opened this issue Aug 4, 2023 · 3 comments
Closed
5 tasks done

[BUG] Popup modal doesn't work in multipage mode #1274

ThinkSalat opened this issue Aug 4, 2023 · 3 comments
Assignees
@Lissy93
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working 🕸️ Inactive

Comments

@ThinkSalat
Copy link
Contributor

Environment

Self-Hosted (Docker)

System

DSM 7.2-64570 Update 3, Docker version 20.10.23, build 876964a, Chrome 114

Version

2.1.1

Describe the problem

In mutli page mode, after switching page, the pop up modals do not work.

  1. Create multiple pages
  2. Open Dashy and switch to a different page using the navigation header
  3. try to open popup modal - nothing will happen and console will show an error:

TypeError: Cannot read properties of undefined (reading 'show') at o.triggerModal (Section.vue:216:1) at Kt (vue.runtime.esm.js:2988:30)

Additional info

sidekick_VwOUU6fCmk

Please tick the boxes
@ThinkSalat ThinkSalat added the 🐛 Bug [ISSUE] Ticket describing something that isn't working label Aug 4, 2023
@ThinkSalat ThinkSalat mentioned this issue Aug 4, 2023
Merged
3 tasks
@liss-bot
Copy link
Collaborator

liss-bot commented Nov 3, 2023

This issue has gone 3 months without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

@liss-bot liss-bot added the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Nov 3, 2023
@github-project-automation github-project-automation bot moved this to Todo in Dashy V3 Nov 3, 2023
Lissy93 added a commit that referenced this issue Nov 3, 2023
@Lissy93
Merge pull request #1275 from ThinkSalat/bug/1274-popup-modal-fix
d2e4949 
bug #1274 multi page popup modal fix
@liss-bot
Copy link
Collaborator

liss-bot commented Nov 8, 2023

This issue was automatically closed because it has been stalled for over 6 weeks with no activity.

@liss-bot liss-bot closed this as completed Nov 8, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Dashy V3 Nov 8, 2023
@liss-bot liss-bot removed the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Nov 8, 2023
@cyrus104
Copy link

Is there any way we can reopen this? I have pretty much the exact same setup and modal does not work!!!

I can right click and open in any way BUT modal.

CrazyWolf13 added a commit to CrazyWolf13/dashy that referenced this issue Feb 11, 2024
@CrazyWolf13
Revert "bug Lissy93#1274 multi page popup modal fix"
f2641de
Lissy93 added a commit that referenced this issue Feb 22, 2024
@Lissy93
🔀 Merge pull request #1464 from CrazyWolf13/revert-1275-bug/1274-popu…
644476c 
…p-modal-fix

Revert "bug #1274 multi page popup modal fix"
Fixes #1375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lissy93 Lissy93

Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working 🕸️ Inactive
Projects
Dashy V3
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cyrus104 @Lissy93 @ThinkSalat @liss-bot