TOB-LSK-4: Trivial loop condition in snapshot creation (#17)

🔨 Refactor while loop
LiskHQ · Mar 20, 2024 · 8487ed0 · 8487ed0
1 parent 3d49c88
commit 8487ed0
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/packages/tree-builder/src/applications/generate-merkle-tree/create_snapshot.ts b/packages/tree-builder/src/applications/generate-merkle-tree/create_snapshot.ts
@@ -46,7 +46,9 @@ async function iterate(
 ) {
 	let start = Buffer.alloc(ADDRESS_LENGTH, 0);
 	let lastProcessedAddress: Buffer;
-	do {
+
+	// eslint-disable-next-line no-constant-condition
+	while (true) {
 		const stream = rdb.iterate({
 			gte: Buffer.concat([prefixBuffer, start, postfixBuffer]),
 			lte: Buffer.concat([prefixBuffer, Buffer.alloc(ADDRESS_LENGTH, 255), postfixBuffer]),
@@ -74,7 +76,7 @@ async function iterate(
 			break;
 		}
 		start = incrementBufferWithOverflow(lastProcessedAddress);
-	} while (lastProcessedAddress);
+	}
 }
 
 export async function createSnapshot(db: StateDB, tokenId: Buffer): Promise<Account[]> {