Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor request token link generation #5482

Merged
merged 6 commits into from
Nov 25, 2023

Conversation

eniolam1000752
Copy link
Contributor

@eniolam1000752 eniolam1000752 commented Nov 22, 2023

What was the problem?

This PR resolves #5481

How was it solved?

  • Change link generated on request token from using the lisk: domain to the lisk https: domain.
  • Fix failing tests

How was it tested?

  • Request token
  • https://lisk.com/send?<reset of the required query params> should be copied to the clip board.

@ManuGowda ManuGowda requested review from ikem-legend and removed request for Balanced02 November 24, 2023 12:39
@ManuGowda ManuGowda removed the request for review from ikem-legend November 24, 2023 15:44
@ManuGowda
Copy link
Contributor

Works as expected.

@ManuGowda ManuGowda merged commit 4eb4e90 into release/3.0.0 Nov 25, 2023
@ManuGowda ManuGowda deleted the 5481-refactor-request-token-link-generation branch November 25, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants