Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zero custom fee #5473

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Fix zero custom fee #5473

merged 3 commits into from
Nov 21, 2023

Conversation

eniolam1000752
Copy link
Contributor

@eniolam1000752 eniolam1000752 commented Nov 20, 2023 •
edited
Loading

What was the problem?

This PR resolves #5447, #5472

How was it solved?

  • Fix conditional statement in getCustomFeeStatus
  • Fix request token issue on no tokens view

How was it tested?

  • Initiate any transaction
  • Enable custom fee
  • Try to edit custom fee to zero
  • You should not be able to commit a zero fee value

@eniolam1000752 eniolam1000752 self-assigned this Nov 20, 2023
@eniolam1000752 eniolam1000752 mentioned this pull request Nov 20, 2023
Merged
3 tasks
ikem-legend
ikem-legend previously approved these changes Nov 20, 2023
View reviewed changes
@ManuGowda ManuGowda requested review from ikem-legend and removed request for oskarleonard November 21, 2023 13:11
@ManuGowda ManuGowda merged commit ca8980a into release/3.0.0 Nov 21, 2023
@ManuGowda ManuGowda deleted the 5447-fix-zero-custom-fee branch November 21, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManuGowda ManuGowda ManuGowda approved these changes

@ikem-legend ikem-legend ikem-legend approved these changes

Assignees

@eniolam1000752 eniolam1000752

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eniolam1000752 @ManuGowda @ikem-legend