🐛 Add edge-case scenario handling for getLogLevel

src/utils/config.ts

@@ -50,8 +50,10 @@ export const getNetworkByNetworkID = (_networkID: string): string | Error => {
 
 export const getLogLevel = (loggerConfig: LoggerConfig): string => {
 	const highestLogPriority = Math.max(
-		LOG_LEVEL_PRIORITY[String(loggerConfig.fileLogLevel).toUpperCase()],
-		LOG_LEVEL_PRIORITY[String(loggerConfig.consoleLogLevel).toUpperCase()],
+		LOG_LEVEL_PRIORITY[String(loggerConfig.fileLogLevel || '').toUpperCase()] ??
+			LOG_LEVEL_PRIORITY.INFO,
+		LOG_LEVEL_PRIORITY[String(loggerConfig.consoleLogLevel || '').toUpperCase()] ??
+			LOG_LEVEL_PRIORITY.INFO,
 	);
 
 	try {

test/unit/utils/config.spec.ts

@@ -21,14 +21,15 @@ import { configV3, configV4 } from '../fixtures/config';
 import { NETWORK_CONSTANT } from '../../../src/constants';
 import {
 	getNetworkByNetworkID,
+	getLogLevel,
 	migrateUserConfig,
 	validateConfig,
 	writeConfig,
 	resolveConfigPathByNetworkID,
 	createBackup,
 	getConfig,
 } from '../../../src/utils/config';
-import { ApplicationConfigV3 } from '../../../src/types';
+import { ApplicationConfigV3, LoggerConfig } from '../../../src/types';
 
 const migratedConfigFilePath = join(__dirname, 'test/config');
 const expectedBackupPath = join(__dirname, '../../..', 'backup');
@@ -38,6 +39,41 @@ const mockCommand = {
 	error,
 };
 
+describe('Test getLogLevel method', () => {
+	it('should return highest priority logLevel provided by user', async () => {
+		const loggerConfig = {
+			fileLogLevel: 'trace',
+			consoleLogLevel: 'error',
+		} as LoggerConfig;
+		const logLevel = getLogLevel(loggerConfig);
+		expect(logLevel).toBe('trace');
+	});
+
+	it('should return info when logger config is not available', async () => {
+		const loggerConfig = {} as LoggerConfig;
+		const logLevel = getLogLevel(loggerConfig);
+		expect(logLevel).toBe('info');
+	});
+
+	it('should return the highest priority log level when one of the specified logLevel is incorrect', async () => {
+		const loggerConfig = {
+			fileLogLevel: 'trace',
+			consoleLogLevel: 'err',
+		} as LoggerConfig;
+		const logLevel = getLogLevel(loggerConfig);
+		expect(logLevel).toBe('trace');
+	});
+
+	it('should return info if the specified valid log level is of lower priority than info and other is incorrect', async () => {
+		const loggerConfig = {
+			fileLogLevel: 'fatal',
+			consoleLogLevel: 'err',
+		} as LoggerConfig;
+		const logLevel = getLogLevel(loggerConfig);
+		expect(logLevel).toBe('info');
+	});
+});
+
 describe('Migrate user configuration', () => {
 	afterAll(() => {
 		fs.removeSync(migratedConfigFilePath);