Fix warnings: Access to a protected member of a class #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wuodan
force-pushed
the
upstream/issue/56_Access-to-a-protected-member-of-a-class
branch
2 times, most recently
from
fb29243 to
1c5ef08
Compare
|
This PR modifies much more than just _storage. Is that intended? |
IntelliJ complains when a protected member is accessed from outside the class. Example: - tminterface2.py: class `TMInterface` has a method `_read_int32()` - add_cp_as_triggers.py: uses the method and has a warning This commit fixes the warnings where possible. The warning is not always correct as found here: trackmania_rl/buffer_utilities.py:280 `target_buffer.extend(source_buffer.storage._storage)` Warning: _ListStorage._storage is not publicly accessible_ is wrong because `ListStorage._storage` is not publicly accessible Fixes Linesight-RL#56
Wuodan
force-pushed
the
upstream/issue/56_Access-to-a-protected-member-of-a-class
branch
from
1c5ef08 to
07c6fc3
Compare
Wuodan
changed the title
|
Rebased the branch on main and changed both the commit message and the PR title/text to better explain the change. Sorry for the confusion. The idea is to fix the warnings wherever possible, the note was about the exception where testing showed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IntelliJ complains when a protected member is accessed from outside the class.
Example:
TMInterfacehas a method_read_int32()This commit fixes the warnings where possible.
The warning is not always correct as found here:
trackmania_rl/buffer_utilities.py:280
target_buffer.extend(source_buffer.storage._storage)Warning: _ListStorage.storage is not publicly accessible is wrong because
ListStorage._storageis not publicly accessibleFixes #56