Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Floating point numbers should not be tested for equality #62

Open
Wuodan opened this issue Aug 21, 2024 · 0 comments · May be fixed by #63
Open

Floating point numbers should not be tested for equality #62

Wuodan opened this issue Aug 21, 2024 · 0 comments · May be fixed by #63

Comments

@Wuodan
Copy link
Contributor

Wuodan commented Aug 21, 2024

linesight/trackmania_rl/analysis_metrics.py

Line 320 in 09d84b5

if (np.min(quantiles_output) == np.max(quantiles_output)) and (np.min(quantiles_output) == 0.0):

see SonarRule python:S1244
Wuodan added a commit to Wuodan/linesight that referenced this issue Aug 21, 2024
@Wuodan
Linesight-RL#62 Floating point numbers should not be tested for equality
d6bcd62 
see SonarRule python:S1244 (https://rules.sonarsource.com/python/RSPEC-1244/)
Wuodan added a commit to Wuodan/linesight that referenced this issue Aug 21, 2024
@Wuodan
Floating point numbers should not be tested for equality
ac51c05 
see SonarRule python:S1244 (https://rules.sonarsource.com/python/RSPEC-1244/)

Fixes Linesight-RL#62
@Wuodan Wuodan linked a pull request Aug 21, 2024 that will close this issue
Open
Wuodan added a commit to Wuodan/linesight that referenced this issue Aug 21, 2024
@Wuodan
Linesight-RL#62 Floating point numbers should not be tested for equality
52ff250 
see SonarRule python:S1244 (https://rules.sonarsource.com/python/RSPEC-1244/)
Wuodan added a commit to Wuodan/linesight that referenced this issue Aug 21, 2024
@Wuodan
Linesight-RL#62 Floating point numbers should not be tested for equality
efa4b17 
see SonarRule python:S1244 (https://rules.sonarsource.com/python/RSPEC-1244/)
Wuodan added a commit to Wuodan/linesight that referenced this issue Aug 21, 2024
@Wuodan
Linesight-RL#62 Floating point numbers should not be tested for equality
927e456 
see SonarRule python:S1244 (https://rules.sonarsource.com/python/RSPEC-1244/)
Wuodan added a commit to Wuodan/linesight that referenced this issue Aug 22, 2024
@Wuodan
Linesight-RL#62 Floating point numbers should not be tested for equality
f314c2c 
see SonarRule python:S1244 (https://rules.sonarsource.com/python/RSPEC-1244/)
Wuodan added a commit to Wuodan/linesight that referenced this issue Aug 30, 2024
@Wuodan
Floating point numbers should not be tested for equality
66104bd 
see SonarRule python:S1244 (https://rules.sonarsource.com/python/RSPEC-1244/)

Fixes Linesight-RL#62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Floating point numbers should not be tested for equality Wuodan/linesight
1 participant
@Wuodan