Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] canary PR #1294

Closed
wants to merge 3 commits into from
Closed

[DO NOT MERGE] canary PR #1294

wants to merge 3 commits into from

Conversation

williamFalcon
Copy link
Contributor

@williamFalcon williamFalcon commented Apr 15, 2024

Non changes shouldn't fail CI... (noticed this when merging #1291)

This implies that:

  • CI has bugs
  • or it's flaky
  • also it's super slow to do certain installs...

image

cc @rasbt @carmocca @Andrei-Aksionov @lantiga

@williamFalcon williamFalcon requested a review from lantiga as a code owner April 15, 2024 16:37
@williamFalcon williamFalcon mentioned this pull request Apr 15, 2024
@rasbt
Copy link
Contributor

rasbt commented Apr 15, 2024

This is perhaps related to this that happened last Fri:

#1272 (comment)

I might be wrong, but it looks like there is a missing pre-build wheel for Python 3.9.
So whenever you try to install this package with this Python, it tries to build a wheel. Since it's written in Rust, it expects a corresponding toolset.
Don't know why before there were no issues, maybe somewhat from HF team accidentally deleted the wheel? 🤷

It looks like hf-transfer==0.1.4 (Nov 6, 2023) can be installed in Python 3.9.19 without problem

@Andrei-Aksionov
Copy link
Contributor

There are two issues:

  1. Starting last week, UV (a replacement for pip install written in Rust) decided that it no longer wants to cooperate with Python 3.9. It cannot find a suitable version of botocore/boto3 (litdata dependency), it checks all the combination starting from the newest package (1.34.x) down to the oldest one (1.10.x), but that doesn't always happen due to timeout. Plus it says that cannot find an crt extension for boto3. While pip install doesn't have any of these issues. This should be solved by Replace UV with regular pip #1292
  2. There is an encoding problem on Windows platform and the newest addition to supported models - CodeGemma. It should be solved by Specify UTF-8 encoding for every open function #1283

@williamFalcon
Copy link
Contributor Author

@Andrei-Aksionov merged #1292 into this PR. However, the tests are still failing.

@Andrei-Aksionov
Copy link
Contributor

Yep, as I stated above: there are 2 issues 😆.
Now it's time to merge #1283 into main and then merge main into this branch.

@williamFalcon
Copy link
Contributor Author

nice. love it. nice job @Andrei-Aksionov @carmocca @rasbt @lantiga

@rasbt rasbt deleted the williamFalcon-patch-1 branch June 6, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants