Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightweight workflow to check for broken markdown links #1271

Merged
merged 7 commits into from
Apr 11, 2024
Merged

Conversation

rasbt
Copy link
Contributor

@rasbt rasbt commented Apr 11, 2024

Since certain people (looking at me!) have a tendency to insert broken markdown links, I think it might be a good idea to check for this as part of the linter.

So, I added a lightweight workflow.

Caveat: It works reliably, but I am not sure how I get it to error if it detects broken links. One has to manually check the report right now. It would be nicer if we could get it to error out if it fails on a link.

@rasbt rasbt enabled auto-merge (squash) April 11, 2024 18:19
@rasbt
Copy link
Contributor Author

rasbt commented Apr 11, 2024

Thanks. I updated it and it works, returning a non-zero exit code when failing one of the link checks. This is ready to be merged now.

@carmocca carmocca disabled auto-merge April 11, 2024 18:26
@carmocca carmocca merged commit 88f6574 into main Apr 11, 2024
8 of 9 checks passed
@carmocca carmocca deleted the link-checker branch April 11, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants