Merge pull request #28 from LeoAndo/release-v1.0.3_

Release v1.0.3
LeoAndo · Mar 11, 2023 · ae5ba98 · ae5ba98
2 parents 171d5a1 + 4a96c9b
commit ae5ba98
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 14 deletions.
diff --git a/SwiftUIGithubSearch.xcodeproj/project.pbxproj b/SwiftUIGithubSearch.xcodeproj/project.pbxproj
@@ -29,10 +29,10 @@
 		AA5947DE29B7459A00C84427 /* Container.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA5947DD29B7459A00C84427 /* Container.swift */; };
 		AA5947E329B74A1D00C84427 /* SearchRepositoriesResponse.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA5947E229B74A1D00C84427 /* SearchRepositoriesResponse.swift */; };
 		AA5947F129B7689800C84427 /* FakeGithubRepoRepository.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA5947F029B7689800C84427 /* FakeGithubRepoRepository.swift */; };
-		AA5947F329B78CE300C84427 /* GithubApiHttpClient.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA5947F229B78CE300C84427 /* GithubApiHttpClient.swift */; };
+		AA5947F329B78CE300C84427 /* GithubHttpClient.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA5947F229B78CE300C84427 /* GithubHttpClient.swift */; };
+		AA96AAE929BC84D900F12CD1 /* HttpClient.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA96AAE829BC84D900F12CD1 /* HttpClient.swift */; };
+		AA96AAEB29BC84F000F12CD1 /* ApiRequest.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA96AAEA29BC84F000F12CD1 /* ApiRequest.swift */; };
 		AAB9097729BC2A3100DBFAB2 /* ValidationError.swift in Sources */ = {isa = PBXBuildFile; fileRef = AAB9097629BC2A3100DBFAB2 /* ValidationError.swift */; };
-		AAB9D70229BC794A00374C45 /* HttpClient.swift in Sources */ = {isa = PBXBuildFile; fileRef = AAB9D70129BC794A00374C45 /* HttpClient.swift */; };
-		AAB9D70429BC79B800374C45 /* ApiRequest.swift in Sources */ = {isa = PBXBuildFile; fileRef = AAB9D70329BC79B800374C45 /* ApiRequest.swift */; };
 		AAC7D7FF29B70A7F00E62354 /* SwiftUIGithubSearchApp.swift in Sources */ = {isa = PBXBuildFile; fileRef = AAC7D7FE29B70A7F00E62354 /* SwiftUIGithubSearchApp.swift */; };
 		AAC7D80129B70A7F00E62354 /* SearchScreen.swift in Sources */ = {isa = PBXBuildFile; fileRef = AAC7D80029B70A7F00E62354 /* SearchScreen.swift */; };
 		AAC7D80329B70A8000E62354 /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = AAC7D80229B70A8000E62354 /* Assets.xcassets */; };
@@ -82,10 +82,10 @@
 		AA5947DD29B7459A00C84427 /* Container.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Container.swift; sourceTree = "<group>"; };
 		AA5947E229B74A1D00C84427 /* SearchRepositoriesResponse.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SearchRepositoriesResponse.swift; sourceTree = "<group>"; };
 		AA5947F029B7689800C84427 /* FakeGithubRepoRepository.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FakeGithubRepoRepository.swift; sourceTree = "<group>"; };
-		AA5947F229B78CE300C84427 /* GithubApiHttpClient.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = GithubApiHttpClient.swift; sourceTree = "<group>"; };
+		AA5947F229B78CE300C84427 /* GithubHttpClient.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = GithubHttpClient.swift; sourceTree = "<group>"; };
+		AA96AAE829BC84D900F12CD1 /* HttpClient.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = HttpClient.swift; sourceTree = "<group>"; };
+		AA96AAEA29BC84F000F12CD1 /* ApiRequest.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ApiRequest.swift; sourceTree = "<group>"; };
 		AAB9097629BC2A3100DBFAB2 /* ValidationError.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ValidationError.swift; sourceTree = "<group>"; };
-		AAB9D70129BC794A00374C45 /* HttpClient.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = HttpClient.swift; sourceTree = "<group>"; };
-		AAB9D70329BC79B800374C45 /* ApiRequest.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ApiRequest.swift; sourceTree = "<group>"; };
 		AAC7D7FB29B70A7F00E62354 /* SwiftUIGithubSearch.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = SwiftUIGithubSearch.app; sourceTree = BUILT_PRODUCTS_DIR; };
 		AAC7D7FE29B70A7F00E62354 /* SwiftUIGithubSearchApp.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SwiftUIGithubSearchApp.swift; sourceTree = "<group>"; };
 		AAC7D80029B70A7F00E62354 /* SearchScreen.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SearchScreen.swift; sourceTree = "<group>"; };
@@ -214,8 +214,8 @@
 				AA5947DA29B7419200C84427 /* Github */,
 				AA5947C129B71E4C00C84427 /* HTTPStatusCode.swift */,
 				AA5947C329B71F2500C84427 /* HTTPMethod.swift */,
-				AAB9D70129BC794A00374C45 /* HttpClient.swift */,
-				AAB9D70329BC79B800374C45 /* ApiRequest.swift */,
+				AA96AAE829BC84D900F12CD1 /* HttpClient.swift */,
+				AA96AAEA29BC84F000F12CD1 /* ApiRequest.swift */,
 			);
 			path = API;
 			sourceTree = "<group>";
@@ -251,7 +251,7 @@
 			children = (
 				AA5947DF29B749E200C84427 /* Response */,
 				AA5947DB29B741AB00C84427 /* GithubService.swift */,
-				AA5947F229B78CE300C84427 /* GithubApiHttpClient.swift */,
+				AA5947F229B78CE300C84427 /* GithubHttpClient.swift */,
 			);
 			path = Github;
 			sourceTree = "<group>";
@@ -492,13 +492,13 @@
 				AA5947E329B74A1D00C84427 /* SearchRepositoriesResponse.swift in Sources */,
 				AA5947D629B7406F00C84427 /* RepositorySummary.swift in Sources */,
 				AAB9097729BC2A3100DBFAB2 /* ValidationError.swift in Sources */,
-				AAB9D70229BC794A00374C45 /* HttpClient.swift in Sources */,
+				AA96AAE929BC84D900F12CD1 /* HttpClient.swift in Sources */,
 				AAC7D80129B70A7F00E62354 /* SearchScreen.swift in Sources */,
 				AAC7D7FF29B70A7F00E62354 /* SwiftUIGithubSearchApp.swift in Sources */,
 				AA5947D929B7413C00C84427 /* GithubRepoRepositoryImpl.swift in Sources */,
 				AA5947D029B73AD900C84427 /* SearchUiState.swift in Sources */,
 				AA5947C229B71E4C00C84427 /* HTTPStatusCode.swift in Sources */,
-				AA5947F329B78CE300C84427 /* GithubApiHttpClient.swift in Sources */,
+				AA5947F329B78CE300C84427 /* GithubHttpClient.swift in Sources */,
 				AA5947DE29B7459A00C84427 /* Container.swift in Sources */,
 				AA5947C429B71F2500C84427 /* HTTPMethod.swift in Sources */,
 				AAE789A029B87EF000A9DEE2 /* GithubErrorResponse.swift in Sources */,
@@ -514,7 +514,7 @@
 				AA24EE0829BA0C570089EC85 /* AppError.swift in Sources */,
 				AAE789A429B8823B00A9DEE2 /* ApplicationError.swift in Sources */,
 				AA24EE0629BA06260089EC85 /* IconWithText.swift in Sources */,
-				AAB9D70429BC79B800374C45 /* ApiRequest.swift in Sources */,
+				AA96AAEB29BC84F000F12CD1 /* ApiRequest.swift in Sources */,
 				AA24EDFD29B9AA100089EC85 /* RepositoryDetailResponse.swift in Sources */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;

diff --git a/SwiftUIGithubSearch/DI/Container.swift b/SwiftUIGithubSearch/DI/Container.swift
@@ -10,7 +10,7 @@ import Factory
 
 extension Container {
     var githubHttpClient: Factory<HttpClient> {
-        self { GithubApiHttpClientImpl() }
+        self { GithubHttpClient() }
     }
     var githubRepoRepository: Factory<GithubRepoRepository> {
         self { GithubRepoRepositoryImpl(self.githubHttpClient()) }

diff --git a/SwiftUIGithubSearch/Data/API/ApiRequest.swift b/SwiftUIGithubSearch/Data/API/ApiRequest.swift
@@ -6,6 +6,7 @@
 //
 import Foundation
 
+/// 実装は各APIごとに用意する
 protocol ApiRequest {
     associatedtype ResponseEntity: Decodable
     var baseURL: String { get }

diff --git a/...Data/API/Github/GithubApiHttpClient.swift → ...ch/Data/API/Github/GithubHttpClient.swift b/...Data/API/Github/GithubApiHttpClient.swift → ...ch/Data/API/Github/GithubHttpClient.swift
@@ -8,7 +8,7 @@
 import Foundation
 import Factory
 
-final class GithubApiHttpClientImpl: HttpClient {
+final class GithubHttpClient: HttpClient {
     func fetch<R>(_ request: R) async throws -> R.ResponseEntity where R : ApiRequest {
         var data: Data?
         var response: URLResponse?

diff --git a/SwiftUIGithubSearch/Data/API/HttpClient.swift b/SwiftUIGithubSearch/Data/API/HttpClient.swift
@@ -4,6 +4,7 @@
 //
 //  Created by LeoAndo on 2023/03/11.
 //
+
 /// 実装は各APIごとに用意する
 protocol HttpClient {
     func fetch<R>(_ request: R) async throws -> R.ResponseEntity where R: ApiRequest