Switch PostgreSQL container to use pgautoupgrade #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniel15
requested review from
Nutomic,
dessalines,
codyro and
ticoombs
as code owners
ticoombs
approved these changes
Aug 16, 2024
codyro
reviewed
Aug 17, 2024
templates/docker-compose.yml
Outdated
| @@ -81,7 +81,7 @@ services: | |||
| logging: *default-logging | |||
|
|
|||
| postgres: | |||
| image: docker.io/postgres:16-alpine | |||
| image: pgautoupgrade/pgautoupgrade:16-alpine | |||
There was a problem hiding this comment.
Would you mind pointing this to the official Docker Hub registry (ex, docker.io/pgautoupgrade/pgautoupgrade) (to avoid any issues with registries.conf, etc)?
dessalines
approved these changes
Aug 19, 2024
ticoombs
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lemmy changed from PostgreSQL 15 to 16 at some point, and trying to switch from 15 to 16 in
docker-compose.ymlresults in errors like this at startup:This PR changes the PostgreSQL container to use pgautoupgrade. The pgautoupgrade image is based on the regular PostgreSQL one, but it automatically updates the data to the newer format on startup. This avoids users having to figure it out manually.
Same change as in LemmyNet/lemmy#4892