🐛 fix isConnected for reversed motors

[toxicdefender404]

get_plugged_type does not work for negative ports which means reversed motors in motor groups do nothing

[Miniongolf]

Shouldn't the ReversibleSmartPort class handle the negative port
If it does, maybe we should switch m_port to a uint32_t to make it clearer

[toxicdefender404]

Shouldn't the ReversibleSmartPort class handle the negative port If it does, maybe we should switch m_port to a uint32_t to make it clearer

Handle it in what way? The issue i see is that the pros motor specific functions don't have a reversed parameter, the only way to reverse them is via a negative port, but all the other functions have a reversed parameter and only work with positive ports.
The cleanest way IMO would be a pr to the pros kernel to make the api consistent but I don't feel like doing that.

[Miniongolf]

Handle it in what way? The issue i see is that the pros motor specific functions don't have a reversed parameter, the only way to reverse them is via a negative port, but all the other functions have a reversed parameter and only work with positive ports. The cleanest way IMO would be a pr to the pros kernel to make the api consistent but I don't feel like doing that.

Ok yeah mb, I conflated the constructor flipping the port to positive when checking for validity with storing the port number as positive.

[SizzinSeal]

LGTM