Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix github protocol drop #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

compermisos
Copy link

lease see https://github.blog/2021-09-01-improving-git-protocol-security-github/

from 11 of january, github drop git:// protocol for un-autenticated users (most automated installs off the lib)

@Lekensteyn
Copy link
Owner

Hi, thank you for your PR. It appears that since LuaRocks 3.8, git://github.com URLs are automatically converted: luarocks/luarocks@9ff512e, so there is not an immediate need for a fix.

Did this change work for you? I would expect it to fail, shouldn't the scheme be git+https instead of https? From https://github.com/luarocks/luarocks/wiki/Rockspec-format#user-content-build_rules:

git:// - for the Git source control manager
git+http:// - for the Git source control manager when using repositories that need http:// URLs
https:// - for HTTPS URLs

Aside from that there are some typos in the commit message.

@compermisos
Copy link
Author

sorry by the typos
in single test, the change run in luarocks 2.4.8
the packaged version in diferents linux distro, is minor of 2.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants