Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New mixins 0.8.7, mixinextras 0.4.1, and ASM 9.7.1 #30

Merged
merged 7 commits into from
Oct 15, 2024

Conversation

mitchej123
Copy link
Contributor

@mitchej123 mitchej123 commented Jul 11, 2024

Bumps UniMix to 0.15.3_mixin.0.8.7, Mixin Extras to 0.4.1, and ASM to 9.7.1

Notes:

  • - Pending - Tested in Full GTNH nightly pack

Previously tested by FalsePattern w/ GTMega and reported to be working

@mitchej123 mitchej123 marked this pull request as draft July 12, 2024 00:35
@mitchej123
Copy link
Contributor Author

Waiting on getting hodgepodge working with the change in shadow behavior, will set to ready again after that's confirmed working.

@embeddedt
Copy link

What changed about Shadow behavior? This may break other mods; we need to be careful about that.

@mitchej123
Copy link
Contributor Author

mitchej123 commented Jul 12, 2024

What changed about Shadow behavior? This may break other mods; we need to be careful about that.

I'm not convinced the shadow behavior was ever supported, or just an unintended side effect that happened to work.

Previously if there was Blah blah = new Blah() and you did @Shadow Blah blah = new Something() it would end up with it being added to the constructor after the initial Blah(). I don't see anything documented indicating this was expected, but it did work.

Now it adds the new Something() significantly earlier in the constructor, and the new Blah() takes precedence.

Still trying to narrow down what change specifically instigated this, and whether it was intentional, or a bad interact with our patches. Having some other oddities booting the pack that I haven't tracked down yet either hence the draft status.

@Roadhog360
Copy link
Member

Yeah. If shadow behavior changed, that would be bad news. But I was under the impression that nothing is really supposed to ever populate shadow fields or functions. It's hard to say what to do in this case because any mods that do this were abusing an unexpected result from mixins instead of using mixins properly, which could have easily achieved the same result.

Then again, we have a certain mod I won't name and probably others that just spam overrides everywhere. So mods not using mixin correctly isn't exactly news.

@jss2a98aj
Copy link
Member

jss2a98aj commented Jul 12, 2024

I think I used the unintended shadow behavior a little bit in BugTorch, though I was not aware it was unintended. I doubt it will introduce any crashes once changed, but I will probably need to fix a few non-critical mixins.

@mitchej123
Copy link
Contributor Author

Pending some investigation and adjustment of behavior upstream. Will likely result in a unimix bump.

@mitchej123
Copy link
Contributor Author

Lyfts confirmed the update in Unimix from upstream FabricMixins fixed this. Will do some additional testing from this PR to ensure everything works properly.

@mitchej123 mitchej123 marked this pull request as ready for review October 14, 2024 18:25
@mitchej123 mitchej123 changed the title New mixins 0.8.7 and mixinextras 0.4.0 New mixins 0.8.7, mixinextras 0.4.1, and ASM 9.7.1 Oct 14, 2024
Copy link
Member

@jss2a98aj jss2a98aj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything appears to be working fine in my setup with these changes. No crashes or incorrect behavior.

@mitchej123 mitchej123 merged commit 5fbb67e into master Oct 15, 2024
2 checks passed
@mitchej123 mitchej123 deleted the new-mixins-and-mixinextras branch October 15, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants