-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New mixins 0.8.7, mixinextras 0.4.1, and ASM 9.7.1 #30
Conversation
MixinExtras -> 0.4.0
Waiting on getting hodgepodge working with the change in shadow behavior, will set to ready again after that's confirmed working. |
What changed about Shadow behavior? This may break other mods; we need to be careful about that. |
I'm not convinced the shadow behavior was ever supported, or just an unintended side effect that happened to work. Previously if there was Now it adds the Still trying to narrow down what change specifically instigated this, and whether it was intentional, or a bad interact with our patches. Having some other oddities booting the pack that I haven't tracked down yet either hence the draft status. |
Yeah. If shadow behavior changed, that would be bad news. But I was under the impression that nothing is really supposed to ever populate shadow fields or functions. It's hard to say what to do in this case because any mods that do this were abusing an unexpected result from mixins instead of using mixins properly, which could have easily achieved the same result. Then again, we have a certain mod I won't name and probably others that just spam overrides everywhere. So mods not using mixin correctly isn't exactly news. |
I think I used the unintended shadow behavior a little bit in BugTorch, though I was not aware it was unintended. I doubt it will introduce any crashes once changed, but I will probably need to fix a few non-critical mixins. |
Pending some investigation and adjustment of behavior upstream. Will likely result in a unimix bump. |
Lyfts confirmed the update in Unimix from upstream FabricMixins fixed this. Will do some additional testing from this PR to ensure everything works properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything appears to be working fine in my setup with these changes. No crashes or incorrect behavior.
Bumps UniMix to 0.15.3_mixin.0.8.7, Mixin Extras to 0.4.1, and ASM to 9.7.1
Notes:
Previously tested by FalsePattern w/ GTMega and reported to be working