Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry sync v2 - StatusEffect and Potion #187

Conversation

thecatcore
Copy link
Member

@thecatcore thecatcore commented Feb 28, 2025

What does this module do:

Status Effects

  • Register vanilla Status Effect registry into Registry sync v2 system
  • Set status effect translation key from identifier when registering it
  • [NEW] Make some useful method on StatusEffect class public.

[NEW] Potion

  • [NEW] For 1.9+, register vanilla Potion registry into Registry sync v2 system
  • [NEW] For 1.9+, add helper functions to register Potion types and recipes
  • [NEW] For pre-1.9, add helper functions to register Potion levels and amplifying factors
  • [NEW] For pre-1.9, ensure potion item's effects id are remapped at the same time status effects are.
  • [NEW] For pre-1.9, ensure potion levels, amplifying factors and colors are remapped at the same time status effects are.

@thecatcore thecatcore added enhancement New feature or request new module New module bikeshed yes labels Feb 28, 2025
@thecatcore thecatcore added this to the 1.12.0 milestone Feb 28, 2025
@thecatcore thecatcore merged commit 172e29a into Legacy-Fabric:feature/registry-sync-v2/main Mar 2, 2025
2 checks passed
@thecatcore thecatcore deleted the feature/registry-sync-v2/effect branch March 2, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bikeshed yes enhancement New feature or request new module New module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants