Registry sync v2 - API #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
This was referenced May 8, 2024
thecatcore
added
enhancement
- differentiate "synced" Index-Key-Value registries from simple Key-Value registries - start preparing registry remapping
BoogieMonster1O1
requested changes
Oct 5, 2024
...2.2/src/main/java/net/legacyfabric/fabric/mixin/networking/versioned/PacketByteBufMixin.java
Outdated
Show resolved
Hide resolved
legacy-fabric-api-base/common/src/main/java/net/legacyfabric/fabric/api/util/Identifier.java
Show resolved
Hide resolved
....10/src/main/java/net/legacyfabric/fabric/mixin/networking/versioned/PacketByteBufMixin.java
Outdated
Show resolved
Hide resolved
...8.9/src/main/java/net/legacyfabric/fabric/mixin/networking/versioned/PacketByteBufMixin.java
Outdated
Show resolved
Hide resolved
...istry-sync-api-v1/common/src/main/java/net/legacyfabric/fabric/api/registry/v1/BiomeIds.java
Outdated
Show resolved
Hide resolved
...-api-v1/common/src/main/java/net/legacyfabric/fabric/api/registry/v1/BlockEntityTypeIds.java
Outdated
Show resolved
Hide resolved
...2/common/src/main/java/net/legacyfabric/fabric/api/registry/v2/registry/holder/Registry.java
Outdated
Show resolved
Hide resolved
…nc-v2/api # Conflicts: # legacy-fabric-registry-sync-api-v1/1.7.10/src/main/resources/registrysync.accesswidener # legacy-fabric-registry-sync-api-v1/1.8/src/main/resources/registrysync.accesswidener # legacyfabric-api/1.10.2/src/testmod/java/net/legacyfabric/fabric/test/registry/RegistryTest.java # legacyfabric-api/1.11.2/src/testmod/java/net/legacyfabric/fabric/test/registry/RegistryTest.java # legacyfabric-api/1.12.2/src/testmod/java/net/legacyfabric/fabric/test/registry/RegistryTest.java # legacyfabric-api/1.7.10/src/testmod/java/net/legacyfabric/fabric/test/registry/RegistryTest.java # legacyfabric-api/1.8.9/src/testmod/java/net/legacyfabric/fabric/test/registry/RegistryTest.java # legacyfabric-api/1.8/src/testmod/java/net/legacyfabric/fabric/test/registry/RegistryTest.java
thecatcore
added
MC1.8.9
ENDERZOMBI102
approved these changes
Dec 8, 2024
thecatcore
merged commit 0524871
into
Legacy-Fabric:feature/registry-sync-v2/main
2 checks passed
thecatcore
added a commit
that referenced
this pull request
Feb 27, 2025
* Initial work on registry-sync-v2 * More progress on registry api v2 - differentiate "synced" Index-Key-Value registries from simple Key-Value registries - start preparing registry remapping * Start working on new registry remapper * Rename some classes * Port remapping system to v2 and port to every supported version * Ensure backward compatibility with registry-sync-api-v1 * Fix a few possible crashes when using registries * Add more useful methods to RegistryHelper * Make vanilla registries first assignable id 1 instead of 0 * Some improvements and bug fixes. * Create a default implementation of IdsHolder and SyncedRegistrableRegistry. * Start working on wrapper for non-standard registry forms * Clean up and fix style * Fix missing events in MapRegistryWrapper * Avoid using sysout * Allow Synchronized Registry to declare themselves not to be synchronized * Allow setting the min id possible of a registry * Fix entry count in IdsHolder * SyncedArrayMapRegistryWrapper * Make Map+Array-based registry min id be 1 instead of 0 * SyncedArrayRegistryWrapper * RegistryWrapper Improvements * Fix defaulted registries default value not being interpreted as entry missing when it should. * Fix defaulted registries default value not being interpreted as entry missing when it should. (again) * Allow registering multiple entries together with a defined offset between their numerical ids. * Fix missing ids being taken over by new entries when entering an existing world * Fix style * Fix style and compiling errors * Disable complex registering for now * Clean up registry-sync-v1 * apache commons lang3 isn't available in 1.7.10 * Fix some parameter names * Add javadoc to deprecated classes and members * Rename some api classes/interfaces * Fix style * Small mixins clean-up * Document registry-sync-v2 apis + Add missing utility methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New registry api, more extensible, only handles registry infrastructure (remapping included).
Individual registries for content are moved to their own module in other pr depending on this one.