feat: init ldmk-transport pkg #8092
Open
+361
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
jdabbech-ledger
requested changes
Oct 14, 2024
| @@ -0,0 +1,56 @@ | |||
| { | |||
| "name": "@ledgerhq/ldmk-transport", | |||
There was a problem hiding this comment.
shouldn't it be named @ledgerhq/live-dmdk ?
| } from "@ledgerhq/device-management-kit"; | ||
| import { BehaviorSubject, firstValueFrom } from "rxjs"; | ||
|
|
||
| const deviceSdk = new DeviceSdkBuilder().addLogger(new ConsoleLogger(LogLevel.Debug)).build(); |
There was a problem hiding this comment.
You should use the latest version and builder.addCustomTransport(DMDKTransport) here with a transport defined as class DMDKTransport extends Transport
There was a problem hiding this comment.
@jdabbech-ledger it's a LL Transport here not a LDMK transport
There was a problem hiding this comment.
It's a transport like other ledger live transports, but it's a wrapper around the LDMK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Created LDMK transport package
❓ Context
🧐 Checklist for the PR Reviewers