feat(web3Hub): add recently used #8050
Open
+312
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
ComradeAERGO
reviewed
Oct 9, 2024
Justkant
reviewed
Oct 10, 2024
apps/ledger-live-mobile/ios/ledgerlivemobile.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
Justkant
reviewed
Oct 10, 2024
...ger-live-mobile/src/newArch/features/Web3Hub/components/Disclaimer/useDisclaimerViewModel.ts
Show resolved
Hide resolved
Justkant
reviewed
Oct 10, 2024
| expect(screen.getByRole("searchbox")).toBeEnabled(); | ||
|
|
||
| expect(await screen.findByText("Recently used")).toBeOnTheScreen(); | ||
| expect(await screen.findByTestId("recently-used-dummy-0")).toBeOnTheScreen(); |
There was a problem hiding this comment.
We also want to limit the usage of testIds to the bare minimum and try to use other user friendly way to find elements
https://testing-library.com/docs/queries/about#priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
demo-recently-used.mp4
❓ Context
🧐 Checklist for the PR Reviewers