Merge pull request #19 from Leaseweb/dev_to_main

develop to main

Bring all but a few changes from develop to the main branch

.github/workflows/go-coverage.yml

@@ -9,12 +9,12 @@ on:
 
 jobs:
   build:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-go@v2
+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@v5
         with:
-          go-version: 1.19.3
+          go-version: '1.21'
       - name: Run go test with coverage
         run: COVER_PROFILE=coverage.txt make test
       - name: Codecov upload

.github/workflows/pr-check.yml

@@ -0,0 +1,46 @@
+name: PR Check
+
+on:
+  pull_request: {}
+
+jobs:
+  lint:
+    name: Lint
+    runs-on: ubuntu-20.04
+    steps:
+      - name: Install Go 1.x
+        uses: actions/setup-go@v5
+        with:
+          go-version: '1.21'
+
+      - name: Check out code
+        uses: actions/checkout@v4
+
+      - name: Run unit tests
+        run: make lint
+
+  build:
+    name: Test & Build
+    runs-on: ubuntu-20.04
+    steps:
+      - name: Install Go 1.x
+        uses: actions/setup-go@v5
+        with:
+          go-version: '1.21'
+
+      - name: Check out code
+        uses: actions/checkout@v4
+
+      - name: Cache
+        uses: actions/cache@v3
+        with:
+          path: ~/go/pkg/mod
+          key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
+          restore-keys: |
+            ${{ runner.os }}-go-
+
+      - name: Run unit tests
+        run: make test
+
+      - name: Build
+        run: make build

.github/workflows/release.yml

@@ -0,0 +1,92 @@
+name: Release
+
+on:
+  push:
+    branches:
+      - main
+      - develop
+    tags:
+      - v*
+
+env:
+  REGISTRY: ghcr.io/leaseweb
+  IMAGE_NAME: capi-cloudstack-controller
+  TAG: build
+
+jobs:
+  push:
+    name: Push images
+    runs-on: ubuntu-20.04
+
+    steps:
+      - name: Check out code
+        uses: actions/checkout@v4
+      # This step is run when the branch is main and no tag is set
+      - name: Sets env vars for main
+        run: |
+          echo "TAG=latest" >> $GITHUB_ENV
+        if: github.ref == 'refs/heads/main' && !startsWith(github.ref, 'refs/tags/v')
+
+      # This step is run when the branch is develop
+      - name: Sets env vars for develop
+        run: |
+          echo "TAG=develop" >> $GITHUB_ENV
+        if: github.ref == 'refs/heads/develop'
+
+      # This step is run when there is a tag
+      - name: Sets env vars for tag
+        run: |
+          VERSION=$(echo "${{ github.ref }}" | sed -e 's,.*/\(.*\),\1,' | sed -e 's/^v//')
+          echo "TAG=${VERSION}" >> $GITHUB_ENV
+        if: startsWith(github.ref, 'refs/tags/v')
+
+      - name: Cache
+        uses: actions/cache@v3
+        with:
+          path: ~/go/pkg/mod
+          key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
+          restore-keys: |
+            ${{ runner.os }}-go-
+
+      - name: Build container images
+        run: make docker-build
+
+      - name: Log into registry
+        uses: docker/login-action@v3
+        with:
+          registry: ghcr.io
+          username: ${{github.actor}}
+          password: ${{secrets.GITHUB_TOKEN}}
+
+      - name: Push
+        run: |
+          docker push ${REGISTRY}/${IMAGE_NAME}:${TAG}
+      
+  release:
+    name: Release
+    runs-on: ubuntu-20.04
+
+    # Run only if previous job has succeeded
+    needs: [push]
+
+    # Create a release only for tags v*
+    if: startsWith(github.ref, 'refs/tags/v')
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Build release manifests
+        run: make release-manifests
+
+      - name: Release
+        uses: softprops/action-gh-release@v1
+        with:
+          prerelease: false
+          draft: true
+          fail_on_unmatched_files: true
+          generate_release_notes: true
+          name: ${{ env.TAG }}
+          files: |
+            out/metadata.yaml
+            out/infrastructure-components.yaml

.golangci.yml

@@ -21,6 +21,14 @@ linters-settings:
       limitations under the License.
   gocyclo:
     min-complexity: 15
+  revive:
+    rules:
+      - name: dot-imports
+        arguments:
+          # dot import should be ONLY allowed for ginkgo testing packages
+          allowedPackages:
+            - "github.com/onsi/ginkgo/v2"
+            - "github.com/onsi/gomega"
 
 linters:
   enable:
@@ -32,12 +40,12 @@ linters:
 
 run:
   issues-exit-code: 1
-  skip-dirs:
-    - pkg/mocks
-    - test
 
 issues:
   # Excluding configuration per-path, per-linter, per-text and per-source
+  exclude-dirs:
+    - pkg/mocks
+    - test
   exclude-rules:
     # Exclude some linters from running on tests files.
     - path: _test\.go