fix: when installed typescript version contains 0 it would cause error to be thrown "Expected version to be parsed" #399
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or to be thrown (e.g 5.0.4)
|
LGTM, mind adding a quick test to prevent a regression in the future. Otherwise I'll get it end of day |
|
I added a config for 5.0.4 in the test cases but there seem to be quite a lot of failures, looking at the log it seems the path is not transformed to relative. I've tried few versions such as 5.3.3, 5.0.2, 5.7.3 and 5.5.3 none of them seem to be able to pass the test |
This reverts commit bad81ff.
|
Published in https://github.com/LeDDGroup/typescript-transform-paths/releases/tag/v3.5.5 Thanks for your contribution @anthony-y-zhu14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using this transformer with the rollup typescript plugin but noticed when the installed typescript version is "5.0.4" an error is thrown "Expected version to be parsed".
I believe this is caused by checking the installed version to see if they are undefined by number 0 is also considered to be falsy in javascript causing this check to fail despite having typescript installed correctly