From 739d0236ef056e2e9df0541179621c61ef88e032 Mon Sep 17 00:00:00 2001 From: Ethen Pociask Date: Wed, 4 Sep 2024 21:27:03 -0400 Subject: [PATCH 1/8] chore: CI --- txt | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 txt diff --git a/txt b/txt new file mode 100644 index 000000000..e69de29bb From 038ab9c75d88bc9c8a6576d2b930bab29f4cfbf2 Mon Sep 17 00:00:00 2001 From: Ethen Pociask Date: Wed, 4 Sep 2024 22:12:47 -0400 Subject: [PATCH 2/8] chore: CI - disable lint --- .github/workflows/ci.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 08f928574..e61749999 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -123,14 +123,14 @@ jobs: - name: Build all lint dependencies run: make -j build-node-deps - - name: Lint - uses: golangci/golangci-lint-action@v3 - with: - version: latest - skip-pkg-cache: true - - name: Custom Lint - run: | - go run ./linters ./... + # - name: Lint + # uses: golangci/golangci-lint-action@v3 + # with: + # version: latest + # skip-pkg-cache: true + # - name: Custom Lint + # run: | + # go run ./linters ./... - name: Set environment variables run: | From 6dce5cb077fd309fcd9252eaf220d47cfc25d0c7 Mon Sep 17 00:00:00 2001 From: Ethen Pociask Date: Thu, 5 Sep 2024 22:29:27 -0400 Subject: [PATCH 3/8] chore: bump go-ethereum to latest commit --- go-ethereum | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go-ethereum b/go-ethereum index 1708dd657..bdd61860a 160000 --- a/go-ethereum +++ b/go-ethereum @@ -1 +1 @@ -Subproject commit 1708dd657505bbb8319c0d73bdf27fe386105372 +Subproject commit bdd61860a908ef5b341907b991fd929db84d549c From 042a7bc0b57e0c16bda14c57984426721f9db1a5 Mon Sep 17 00:00:00 2001 From: Ethen Pociask Date: Mon, 9 Sep 2024 02:22:12 -0400 Subject: [PATCH 4/8] fix challenge tests --- cmd/replay/db.go | 1 - go-ethereum | 2 +- staker/challenge_test.go | 91 ++++++++++++------------ system_tests/full_challenge_impl_test.go | 28 ++++++-- system_tests/full_challenge_mock_test.go | 4 +- system_tests/full_challenge_test.go | 5 ++ 6 files changed, 77 insertions(+), 54 deletions(-) diff --git a/cmd/replay/db.go b/cmd/replay/db.go index 63b36526b..8488168a9 100644 --- a/cmd/replay/db.go +++ b/cmd/replay/db.go @@ -36,7 +36,6 @@ func (db PreimageDb) Get(key []byte) ([]byte, error) { return nil, fmt.Errorf("preimage DB attempted to access non-hash key %v", hex.EncodeToString(key)) } - println("Reading pre-image", hex.EncodeToString(hash[:])) return wavmio.ResolveTypedPreimage(arbutil.Keccak256PreimageType, hash) } diff --git a/go-ethereum b/go-ethereum index bdd61860a..5a2943cbe 160000 --- a/go-ethereum +++ b/go-ethereum @@ -1 +1 @@ -Subproject commit bdd61860a908ef5b341907b991fd929db84d549c +Subproject commit 5a2943cbed319de002d3cc326f9404e8c083950d diff --git a/staker/challenge_test.go b/staker/challenge_test.go index 4534b04a2..b86d37629 100644 --- a/staker/challenge_test.go +++ b/staker/challenge_test.go @@ -22,7 +22,6 @@ import ( "github.com/ethereum/go-ethereum/log" "github.com/offchainlabs/nitro/solgen/go/mocksgen" "github.com/offchainlabs/nitro/solgen/go/ospgen" - "github.com/offchainlabs/nitro/validator" "github.com/offchainlabs/nitro/validator/server_arb" ) @@ -256,48 +255,48 @@ func createBaseMachine(t *testing.T, wasmname string, wasmModules []string) *ser return machine } -func TestChallengeToOSP(t *testing.T) { - machine := createBaseMachine(t, "global-state.wasm", []string{"global-state-wrapper.wasm"}) - IncorrectMachine := server_arb.NewIncorrectMachine(machine, 200) - runChallengeTest(t, machine, IncorrectMachine, false, false, 0) -} - -func TestChallengeToFailedOSP(t *testing.T) { - machine := createBaseMachine(t, "global-state.wasm", []string{"global-state-wrapper.wasm"}) - IncorrectMachine := server_arb.NewIncorrectMachine(machine, 200) - runChallengeTest(t, machine, IncorrectMachine, true, false, 0) -} - -func TestChallengeToErroredOSP(t *testing.T) { - machine := createBaseMachine(t, "const.wasm", nil) - IncorrectMachine := server_arb.NewIncorrectMachine(machine, 10) - runChallengeTest(t, machine, IncorrectMachine, false, false, 0) -} - -func TestChallengeToFailedErroredOSP(t *testing.T) { - machine := createBaseMachine(t, "const.wasm", nil) - IncorrectMachine := server_arb.NewIncorrectMachine(machine, 10) - runChallengeTest(t, machine, IncorrectMachine, true, false, 0) -} - -func TestChallengeToTimeout(t *testing.T) { - machine := createBaseMachine(t, "global-state.wasm", []string{"global-state-wrapper.wasm"}) - IncorrectMachine := server_arb.NewIncorrectMachine(machine, 200) - runChallengeTest(t, machine, IncorrectMachine, false, true, 0) -} - -func TestChallengeToTooFar(t *testing.T) { - machine := createBaseMachine(t, "read-inboxmsg-10.wasm", []string{"global-state-wrapper.wasm"}) - Require(t, machine.SetGlobalState(validator.GoGlobalState{PosInBatch: 10})) - incorrectMachine := machine.Clone() - Require(t, incorrectMachine.AddSequencerInboxMessage(10, []byte{0, 1, 2, 3})) - runChallengeTest(t, machine, incorrectMachine, false, false, 9) -} - -func TestChallengeToFailedTooFar(t *testing.T) { - machine := createBaseMachine(t, "read-inboxmsg-10.wasm", []string{"global-state-wrapper.wasm"}) - Require(t, machine.SetGlobalState(validator.GoGlobalState{PosInBatch: 10})) - incorrectMachine := machine.Clone() - Require(t, machine.AddSequencerInboxMessage(10, []byte{0, 1, 2, 3})) - runChallengeTest(t, machine, incorrectMachine, true, false, 11) -} +// func TestChallengeToOSP(t *testing.T) { +// machine := createBaseMachine(t, "global-state.wasm", []string{"global-state-wrapper.wasm"}) +// IncorrectMachine := server_arb.NewIncorrectMachine(machine, 200) +// runChallengeTest(t, machine, IncorrectMachine, false, false, 0) +// } + +// func TestChallengeToFailedOSP(t *testing.T) { +// machine := createBaseMachine(t, "global-state.wasm", []string{"global-state-wrapper.wasm"}) +// IncorrectMachine := server_arb.NewIncorrectMachine(machine, 200) +// runChallengeTest(t, machine, IncorrectMachine, true, false, 0) +// } + +// func TestChallengeToErroredOSP(t *testing.T) { +// machine := createBaseMachine(t, "const.wasm", nil) +// IncorrectMachine := server_arb.NewIncorrectMachine(machine, 10) +// runChallengeTest(t, machine, IncorrectMachine, false, false, 0) +// } + +// func TestChallengeToFailedErroredOSP(t *testing.T) { +// machine := createBaseMachine(t, "const.wasm", nil) +// IncorrectMachine := server_arb.NewIncorrectMachine(machine, 10) +// runChallengeTest(t, machine, IncorrectMachine, true, false, 0) +// } + +// func TestChallengeToTimeout(t *testing.T) { +// machine := createBaseMachine(t, "global-state.wasm", []string{"global-state-wrapper.wasm"}) +// IncorrectMachine := server_arb.NewIncorrectMachine(machine, 200) +// runChallengeTest(t, machine, IncorrectMachine, false, true, 0) +// } + +// func TestChallengeToTooFar(t *testing.T) { +// machine := createBaseMachine(t, "read-inboxmsg-10.wasm", []string{"global-state-wrapper.wasm"}) +// Require(t, machine.SetGlobalState(validator.GoGlobalState{PosInBatch: 10})) +// incorrectMachine := machine.Clone() +// Require(t, incorrectMachine.AddSequencerInboxMessage(10, []byte{0, 1, 2, 3})) +// runChallengeTest(t, machine, incorrectMachine, false, false, 9) +// } + +// func TestChallengeToFailedTooFar(t *testing.T) { +// machine := createBaseMachine(t, "read-inboxmsg-10.wasm", []string{"global-state-wrapper.wasm"}) +// Require(t, machine.SetGlobalState(validator.GoGlobalState{PosInBatch: 10})) +// incorrectMachine := machine.Clone() +// Require(t, machine.AddSequencerInboxMessage(10, []byte{0, 1, 2, 3})) +// runChallengeTest(t, machine, incorrectMachine, true, false, 11) +// } diff --git a/system_tests/full_challenge_impl_test.go b/system_tests/full_challenge_impl_test.go index 2fca53602..88d7a0ee7 100644 --- a/system_tests/full_challenge_impl_test.go +++ b/system_tests/full_challenge_impl_test.go @@ -358,6 +358,14 @@ func RunChallengeTest(t *testing.T, asserterIsCorrect bool, useStubs bool, chall conf.InboxReader.CheckDelay = time.Second if useEigenDA { + t.Log("Using EigenDA configurations for challenge test") + builder.chainConfig = params.ArbitrumDevTestEigenDAConfig() + builder.chainConfig.ArbitrumChainParams.EigenDA = true + builder.nodeConfig.EigenDA = eigenda.EigenDAConfig{ + Enable: true, + Rpc: "http://localhost:4242", + } + chainConfig = params.ArbitrumDevTestEigenDAConfig() chainConfig.ArbitrumChainParams.EigenDA = true conf.EigenDA = eigenda.EigenDAConfig{ @@ -402,9 +410,19 @@ func RunChallengeTest(t *testing.T, asserterIsCorrect bool, useStubs bool, chall challengerRollupAddresses.Bridge = challengerBridgeAddr challengerRollupAddresses.SequencerInbox = challengerSeqInboxAddr challengerL2Info := NewArbTestInfo(t, chainConfig.ChainID) - challengerParams := SecondNodeParams{ - addresses: &challengerRollupAddresses, - initData: &challengerL2Info.ArbInitData, + + var challengerParams SecondNodeParams + if useEigenDA { + challengerParams = SecondNodeParams{ + nodeConfig: conf, + addresses: &challengerRollupAddresses, + initData: &challengerL2Info.ArbInitData, + } + } else { + challengerParams = SecondNodeParams{ + addresses: &challengerRollupAddresses, + initData: &challengerL2Info.ArbInitData, + } } challenger, challengerCleanup := builder.Build2ndNode(t, &challengerParams) defer challengerCleanup() @@ -466,6 +484,8 @@ func RunChallengeTest(t *testing.T, asserterIsCorrect bool, useStubs bool, chall } } + t.Log("WASM MODULE ROOT:", wasmModuleRoot.Hex()) + asserterGenesis := asserterExec.ArbInterface.BlockChain().Genesis() challengerGenesis := challengerExec.ArbInterface.BlockChain().Genesis() if asserterGenesis.Hash() != challengerGenesis.Hash() { @@ -489,6 +509,7 @@ func RunChallengeTest(t *testing.T, asserterIsCorrect bool, useStubs bool, chall } numBlocks := asserterLatestBlock.Number.Uint64() - asserterGenesis.NumberU64() + println("CREATING CHALLENGE") resultReceiver, challengeManagerAddr := CreateChallenge( t, ctx, @@ -508,7 +529,6 @@ func RunChallengeTest(t *testing.T, asserterIsCorrect bool, useStubs bool, chall confirmLatestBlock(ctx, t, l1Info, l1Backend) readers := make([]daprovider.Reader, 1) - if useEigenDA { eigenDA, err := eigenda.NewEigenDA(&conf.EigenDA) diff --git a/system_tests/full_challenge_mock_test.go b/system_tests/full_challenge_mock_test.go index 1e6ac3d58..c6f821745 100644 --- a/system_tests/full_challenge_mock_test.go +++ b/system_tests/full_challenge_mock_test.go @@ -9,15 +9,15 @@ import "testing" func TestMockChallengeManagerAsserterIncorrect(t *testing.T) { defaultWasmRootDir := "" for i := int64(1); i <= makeBatch_MsgsPerBatch*3; i++ { - RunChallengeTest(t, false, true, i, true, defaultWasmRootDir) RunChallengeTest(t, false, true, i, false, defaultWasmRootDir) + RunChallengeTest(t, false, true, i, true, defaultWasmRootDir) } } func TestMockChallengeManagerAsserterCorrect(t *testing.T) { defaultWasmRootDir := "" for i := int64(1); i <= makeBatch_MsgsPerBatch*3; i++ { - RunChallengeTest(t, true, true, i, true, defaultWasmRootDir) RunChallengeTest(t, true, true, i, false, defaultWasmRootDir) + RunChallengeTest(t, true, true, i, true, defaultWasmRootDir) } } diff --git a/system_tests/full_challenge_test.go b/system_tests/full_challenge_test.go index deebfd912..024a778fe 100644 --- a/system_tests/full_challenge_test.go +++ b/system_tests/full_challenge_test.go @@ -17,20 +17,24 @@ func TestChallengeManagerFullAsserterIncorrect(t *testing.T) { t.Parallel() defaultWasmRootDir := "" RunChallengeTest(t, false, false, makeBatch_MsgsPerBatch+1, false, defaultWasmRootDir) + RunChallengeTest(t, false, false, makeBatch_MsgsPerBatch+1, true, defaultWasmRootDir) } + func TestChallengeManagerFullAsserterIncorrectWithPublishedMachine(t *testing.T) { t.Parallel() cr, err := github.LatestConsensusRelease(context.Background()) Require(t, err) machPath := populateMachineDir(t, cr) RunChallengeTest(t, false, true, makeBatch_MsgsPerBatch+1, false, machPath) + RunChallengeTest(t, false, true, makeBatch_MsgsPerBatch+1, true, machPath) } func TestChallengeManagerFullAsserterCorrect(t *testing.T) { t.Parallel() defaultWasmRootDir := "" RunChallengeTest(t, true, false, makeBatch_MsgsPerBatch+2, false, defaultWasmRootDir) + RunChallengeTest(t, true, false, makeBatch_MsgsPerBatch+2, true, defaultWasmRootDir) } func TestChallengeManagerFullAsserterCorrectWithPublishedMachine(t *testing.T) { @@ -39,4 +43,5 @@ func TestChallengeManagerFullAsserterCorrectWithPublishedMachine(t *testing.T) { Require(t, err) machPath := populateMachineDir(t, cr) RunChallengeTest(t, true, true, makeBatch_MsgsPerBatch+2, false, machPath) + RunChallengeTest(t, true, true, makeBatch_MsgsPerBatch+2, true, machPath) } From 8799b62130dfa9866c58783e78f95f56501be95b Mon Sep 17 00:00:00 2001 From: Ethen Pociask Date: Mon, 9 Sep 2024 14:52:28 -0400 Subject: [PATCH 5/8] remove dbug stmts --- cmd/replay/main.go | 2 +- staker/challenge_test.go | 91 ++++++++++++------------ system_tests/full_challenge_impl_test.go | 3 - system_tests/full_challenge_test.go | 1 - txt | 0 5 files changed, 47 insertions(+), 50 deletions(-) delete mode 100644 txt diff --git a/cmd/replay/main.go b/cmd/replay/main.go index 34b749edc..6666f5f6b 100644 --- a/cmd/replay/main.go +++ b/cmd/replay/main.go @@ -246,9 +246,9 @@ func main() { if dasEnabled { // DAS batch and keysets are all together in the same preimage binary. dasReader = &PreimageDASReader{} + dasKeysetFetcher = &PreimageDASReader{} } else if eigenDAEnabled { eigenDAReader = &EigenDAPreimageReader{} - dasKeysetFetcher = &PreimageDASReader{} } backend := WavmInbox{} var keysetValidationMode = daprovider.KeysetPanicIfInvalid diff --git a/staker/challenge_test.go b/staker/challenge_test.go index b86d37629..4534b04a2 100644 --- a/staker/challenge_test.go +++ b/staker/challenge_test.go @@ -22,6 +22,7 @@ import ( "github.com/ethereum/go-ethereum/log" "github.com/offchainlabs/nitro/solgen/go/mocksgen" "github.com/offchainlabs/nitro/solgen/go/ospgen" + "github.com/offchainlabs/nitro/validator" "github.com/offchainlabs/nitro/validator/server_arb" ) @@ -255,48 +256,48 @@ func createBaseMachine(t *testing.T, wasmname string, wasmModules []string) *ser return machine } -// func TestChallengeToOSP(t *testing.T) { -// machine := createBaseMachine(t, "global-state.wasm", []string{"global-state-wrapper.wasm"}) -// IncorrectMachine := server_arb.NewIncorrectMachine(machine, 200) -// runChallengeTest(t, machine, IncorrectMachine, false, false, 0) -// } - -// func TestChallengeToFailedOSP(t *testing.T) { -// machine := createBaseMachine(t, "global-state.wasm", []string{"global-state-wrapper.wasm"}) -// IncorrectMachine := server_arb.NewIncorrectMachine(machine, 200) -// runChallengeTest(t, machine, IncorrectMachine, true, false, 0) -// } - -// func TestChallengeToErroredOSP(t *testing.T) { -// machine := createBaseMachine(t, "const.wasm", nil) -// IncorrectMachine := server_arb.NewIncorrectMachine(machine, 10) -// runChallengeTest(t, machine, IncorrectMachine, false, false, 0) -// } - -// func TestChallengeToFailedErroredOSP(t *testing.T) { -// machine := createBaseMachine(t, "const.wasm", nil) -// IncorrectMachine := server_arb.NewIncorrectMachine(machine, 10) -// runChallengeTest(t, machine, IncorrectMachine, true, false, 0) -// } - -// func TestChallengeToTimeout(t *testing.T) { -// machine := createBaseMachine(t, "global-state.wasm", []string{"global-state-wrapper.wasm"}) -// IncorrectMachine := server_arb.NewIncorrectMachine(machine, 200) -// runChallengeTest(t, machine, IncorrectMachine, false, true, 0) -// } - -// func TestChallengeToTooFar(t *testing.T) { -// machine := createBaseMachine(t, "read-inboxmsg-10.wasm", []string{"global-state-wrapper.wasm"}) -// Require(t, machine.SetGlobalState(validator.GoGlobalState{PosInBatch: 10})) -// incorrectMachine := machine.Clone() -// Require(t, incorrectMachine.AddSequencerInboxMessage(10, []byte{0, 1, 2, 3})) -// runChallengeTest(t, machine, incorrectMachine, false, false, 9) -// } - -// func TestChallengeToFailedTooFar(t *testing.T) { -// machine := createBaseMachine(t, "read-inboxmsg-10.wasm", []string{"global-state-wrapper.wasm"}) -// Require(t, machine.SetGlobalState(validator.GoGlobalState{PosInBatch: 10})) -// incorrectMachine := machine.Clone() -// Require(t, machine.AddSequencerInboxMessage(10, []byte{0, 1, 2, 3})) -// runChallengeTest(t, machine, incorrectMachine, true, false, 11) -// } +func TestChallengeToOSP(t *testing.T) { + machine := createBaseMachine(t, "global-state.wasm", []string{"global-state-wrapper.wasm"}) + IncorrectMachine := server_arb.NewIncorrectMachine(machine, 200) + runChallengeTest(t, machine, IncorrectMachine, false, false, 0) +} + +func TestChallengeToFailedOSP(t *testing.T) { + machine := createBaseMachine(t, "global-state.wasm", []string{"global-state-wrapper.wasm"}) + IncorrectMachine := server_arb.NewIncorrectMachine(machine, 200) + runChallengeTest(t, machine, IncorrectMachine, true, false, 0) +} + +func TestChallengeToErroredOSP(t *testing.T) { + machine := createBaseMachine(t, "const.wasm", nil) + IncorrectMachine := server_arb.NewIncorrectMachine(machine, 10) + runChallengeTest(t, machine, IncorrectMachine, false, false, 0) +} + +func TestChallengeToFailedErroredOSP(t *testing.T) { + machine := createBaseMachine(t, "const.wasm", nil) + IncorrectMachine := server_arb.NewIncorrectMachine(machine, 10) + runChallengeTest(t, machine, IncorrectMachine, true, false, 0) +} + +func TestChallengeToTimeout(t *testing.T) { + machine := createBaseMachine(t, "global-state.wasm", []string{"global-state-wrapper.wasm"}) + IncorrectMachine := server_arb.NewIncorrectMachine(machine, 200) + runChallengeTest(t, machine, IncorrectMachine, false, true, 0) +} + +func TestChallengeToTooFar(t *testing.T) { + machine := createBaseMachine(t, "read-inboxmsg-10.wasm", []string{"global-state-wrapper.wasm"}) + Require(t, machine.SetGlobalState(validator.GoGlobalState{PosInBatch: 10})) + incorrectMachine := machine.Clone() + Require(t, incorrectMachine.AddSequencerInboxMessage(10, []byte{0, 1, 2, 3})) + runChallengeTest(t, machine, incorrectMachine, false, false, 9) +} + +func TestChallengeToFailedTooFar(t *testing.T) { + machine := createBaseMachine(t, "read-inboxmsg-10.wasm", []string{"global-state-wrapper.wasm"}) + Require(t, machine.SetGlobalState(validator.GoGlobalState{PosInBatch: 10})) + incorrectMachine := machine.Clone() + Require(t, machine.AddSequencerInboxMessage(10, []byte{0, 1, 2, 3})) + runChallengeTest(t, machine, incorrectMachine, true, false, 11) +} diff --git a/system_tests/full_challenge_impl_test.go b/system_tests/full_challenge_impl_test.go index 88d7a0ee7..91b2cb80b 100644 --- a/system_tests/full_challenge_impl_test.go +++ b/system_tests/full_challenge_impl_test.go @@ -484,8 +484,6 @@ func RunChallengeTest(t *testing.T, asserterIsCorrect bool, useStubs bool, chall } } - t.Log("WASM MODULE ROOT:", wasmModuleRoot.Hex()) - asserterGenesis := asserterExec.ArbInterface.BlockChain().Genesis() challengerGenesis := challengerExec.ArbInterface.BlockChain().Genesis() if asserterGenesis.Hash() != challengerGenesis.Hash() { @@ -509,7 +507,6 @@ func RunChallengeTest(t *testing.T, asserterIsCorrect bool, useStubs bool, chall } numBlocks := asserterLatestBlock.Number.Uint64() - asserterGenesis.NumberU64() - println("CREATING CHALLENGE") resultReceiver, challengeManagerAddr := CreateChallenge( t, ctx, diff --git a/system_tests/full_challenge_test.go b/system_tests/full_challenge_test.go index 024a778fe..f8c92a00e 100644 --- a/system_tests/full_challenge_test.go +++ b/system_tests/full_challenge_test.go @@ -20,7 +20,6 @@ func TestChallengeManagerFullAsserterIncorrect(t *testing.T) { RunChallengeTest(t, false, false, makeBatch_MsgsPerBatch+1, true, defaultWasmRootDir) } - func TestChallengeManagerFullAsserterIncorrectWithPublishedMachine(t *testing.T) { t.Parallel() cr, err := github.LatestConsensusRelease(context.Background()) diff --git a/txt b/txt deleted file mode 100644 index e69de29bb..000000000 From 49df6bf84a80adb6f1ef9711b8242bd8d0d1a98a Mon Sep 17 00:00:00 2001 From: Ethen Pociask Date: Mon, 9 Sep 2024 14:55:41 -0400 Subject: [PATCH 6/8] pin lint --- .github/workflows/ci.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e61749999..9f84ddabc 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -123,14 +123,14 @@ jobs: - name: Build all lint dependencies run: make -j build-node-deps - # - name: Lint - # uses: golangci/golangci-lint-action@v3 - # with: - # version: latest - # skip-pkg-cache: true - # - name: Custom Lint - # run: | - # go run ./linters ./... + - name: Lint + uses: golangci/golangci-lint-action@v3 + with: + version: v1.59.0 + skip-pkg-cache: true + - name: Custom Lint + run: | + go run ./linters ./... - name: Set environment variables run: | From 7b1088c4706fa9256c195f7ca9e91abc304214e5 Mon Sep 17 00:00:00 2001 From: Ethen Pociask Date: Mon, 9 Sep 2024 14:56:00 -0400 Subject: [PATCH 7/8] bump contracts --- contracts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contracts b/contracts index 2ac6e8160..462f69a88 160000 --- a/contracts +++ b/contracts @@ -1 +1 @@ -Subproject commit 2ac6e8160bd64eb6a36dd8484b91f1ba8d492ea5 +Subproject commit 462f69a88ac74ee489c23d86c1818e9ae3c86fc8 From 05bdba47918c8dbc297e2af38b1de24856646171 Mon Sep 17 00:00:00 2001 From: Ethen Pociask Date: Mon, 9 Sep 2024 14:58:16 -0400 Subject: [PATCH 8/8] bump back contracts --- contracts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contracts b/contracts index 462f69a88..44895f80e 160000 --- a/contracts +++ b/contracts @@ -1 +1 @@ -Subproject commit 462f69a88ac74ee489c23d86c1818e9ae3c86fc8 +Subproject commit 44895f80e8225a02a722379ab24c125f851e10db