chore: merge upstream v3.0 release changes #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: ignore npm audit issues and bump packages
Co-authored-by: gzeon <im@gzeon.dev>
* chore: effectively disableing delay buffer * chore: typo Co-authored-by: Henry <11198460+godzillaba@users.noreply.github.com> --------- Co-authored-by: Henry <11198460+godzillaba@users.noreply.github.com>
* refactor: move hardcoded value to config * refactor: minimumAssertionPeriod and validatorAfkBlocks in bold upgrade setting * perf: remove onchain verification * chore: update sigs * refactor: remove hardcode in rollup initialize * chore: update example * test: new config param * fix: format test * test: fix config * Apply suggestions from code review Co-authored-by: Henry <11198460+godzillaba@users.noreply.github.com> --------- Co-authored-by: Henry <11198460+godzillaba@users.noreply.github.com>
* docs: add note regarding reorg * wip: use create2 * edit comment * start over * use create2 in bridge creator * require rollup exists * fix tests * fix lint * Revert "docs: add note regarding reorg" This reverts commit d451b7264ccc43f83249d91eefcfe13b1c98ad99. * remove unnecessary args from salt * fmt * put the salt args back * refactor: move hardcoded value to config * refactor: minimumAssertionPeriod and validatorAfkBlocks in bold upgrade setting * perf: remove onchain verification * chore: update sigs * refactor: remove hardcode in rollup initialize * chore: update example * test: new config param * fix: format * fix: BridgeTemplates * fix: memory * fix: format test * feat: use msg.data hash as salt * test: fix * test: fix config * fix: slither * refactor: bridge creator create2Salt * chore: remove unintended change * chore: slither --------- Co-authored-by: gzeon <im@gzeon.dev> Co-authored-by: gzeon <hng@offchainlabs.com>
* update links in README.md * update link in README.md update link to deployed nitro contract addresses * adding #core-contracts to end of link text --------- Co-authored-by: gzeon <h@arry.io>
* update links in README.md (#276) * update links in README.md * update link in README.md update link to deployed nitro contract addresses * adding #core-contracts to end of link text --------- Co-authored-by: gzeon <h@arry.io> * fix: new foundry storage format * fix: CacheManager storage --------- Co-authored-by: Allan <agulley@offchainlabs.com>
fix: merge doc fixes into main
test: improve coverage
* v3.0.0 * chore: bold upgrade deployment (#283) * chore: hardcode deployed * chore: arb1 bold upgrade action * chore: hardcode deployed for nova * chore: nova bold upgrade action * fix: format * revert: hardcoded values
litt3
approved these changes
Jan 16, 2025
0x0aa0
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considerations or things to get done before we can release
1 - Storage buffer for
SequencerInboxwill need size decremented to avoid storage collisions with subsequent upgrades.2 - A new
DelayBuffertype is supported to help with sequencer censorship and deposit tx throttling. When enabled the sequencer has to provide aDelayProofwith a message preimage which is validated against the delayed accumulator before the batch can be considered processed. This feature introduces new entrypoints for each DA type - we'll need to also extend this for support with EigenDA as well.3 -
eigenDARollupManagerisn't set as a part of the creator template. Realistically it should be though since its a stateless implementation contract. Having our customers undergo the burden of deploying their isn't very scalable.4 - eigenda-utils is out-of-date -> lets figure out a way to update it in a way that's decently maintainable.
^ Will file github issues and tackle once this is merged.