Update RollupCreator #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
0x0aa0
commented
Dec 4, 2024
0x0aa0
commented
- template is immutable and set on deployment with a version
- owner cannot update template but can instead freeze further deployment
src/rollup/RollupCreator.sol
Outdated
|
|
||
| function setTemplates( | ||
| constructor( |
There was a problem hiding this comment.
biggest concern with removing setTemplates is that this new patten breaks the deploy script flows: https://github.com/Layr-Labs/nitro-contracts/blob/eigenda-v2.1.0/scripts/local-deployment/deployCreator.ts#L50-L66
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.