v3.0.3: OSP Fixes and Cleanups #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anupsv
changed the base branch from
eigenda-v3.0.3
to
arch/contract-updates-v3.0.3
bxue-l2
reviewed
Aug 15, 2024
src/osp/OneStepProverHostIo.sol
Outdated
| require(z < BN254.FR_MODULUS, "Z_LARGER_THAN_FIELD"); | ||
| require(y < BN254.FR_MODULUS, "Y_LARGER_THAN_FIELD"); | ||
|
|
||
| require((keccak256(kzgProof[224:288]) == bytes32(kzgProof[:32])) && (bytes32(kzgProof[:32]) == leafContents), "KZG_PROOF_WRONG_HASH"); |
There was a problem hiding this comment.
I remembered we hashed datalength into the data too. why is it correct here
There was a problem hiding this comment.
It appears that the place where we hash data and length isn't referenced here and seems to be isolated away. In this code it appears that the data for the msp tree is from the other way the hash is created. This is the same way for 4844 from what I can tell. Interesting part is, even if we match the hash data to each other, there is still no connection between the 2 systems on the contract level. Maybe something offchain does.
…data hash calculation logic
…tracts into epociask--length-fixes-v3.0.3
fix: Include length in preimage hash generation
EthenNotEthan
changed the base branch from
arch/contract-updates-v3.0.3
to
eigenda-v3.0.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: