Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make every flakey test write to its own files #129

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

MegaRedHand
Copy link
Contributor

@MegaRedHand MegaRedHand commented Feb 25, 2025

This PR fixes our flakey tests by making each test that writes to the filesystem do it to files not read or written to in other tests.

All flakey tests seem to be gone when running this script:

#!/usr/bin/env bash

set -e
cd contracts
forge build

for i in {1..100} ; do
    forge test
done

@MegaRedHand MegaRedHand changed the title test: simplify handling of test data fix: make every test write to different files Feb 25, 2025
@MegaRedHand MegaRedHand marked this pull request as ready for review February 25, 2025 19:38
@MegaRedHand MegaRedHand changed the title fix: make every test write to different files fix: make every flakey test write to its own files Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant