Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EgnKey] Generate ECDSA and BLS keys with both-key-type #61

Merged
merged 6 commits into from
Oct 31, 2023
Merged

[EgnKey] Generate ECDSA and BLS keys with both-key-type #61

merged 6 commits into from
Oct 31, 2023

Conversation

siddimore
Copy link
Contributor

@siddimore siddimore commented Oct 25, 2023 •
edited
Loading

Fixes # .

Motivation

  1. Create ECDSA and BLS keys using both key-type
  2. Prefix UUID folder name with ecdsa- and bls- to know the dir type

Solution

  1. Move some methods to common
  2. Add key-type both

@siddimore siddimore requested a review from samlaf October 25, 2023 15:07
@siddimore siddimore changed the title [EgnKey] Generate both ECDS and BLS keys [EgnKey] Generate ECDSA and BLS keys with both-key-type Oct 25, 2023
@shrimalmadhur
Copy link
Collaborator

can you also add this log message - then I can abandon my PR - https://github.com/Layr-Labs/eigensdk-go/pull/60/files#diff-530ece94ffa448cc7378e79ed63557d2f0f454ff2e904ee1411c197a4a3820e3R151

can add these in both ecdsa, bls

@shrimalmadhur
Copy link
Collaborator

Also please update the readme for the usage of both type and explain what it does.

@shrimalmadhur shrimalmadhur merged commit 28e8426 into master Oct 31, 2023
@shrimalmadhur shrimalmadhur deleted the generate_both_keys branch October 31, 2023 19:55
This was referenced Oct 31, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrimalmadhur shrimalmadhur shrimalmadhur approved these changes

@samlaf samlaf Awaiting requested review from samlaf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siddimore @shrimalmadhur