-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add set account identifier function #542
Merged
MegaRedHand
merged 11 commits into
Layr-Labs:dev
from
lambdaclass:feat/add-set-account-identifier-function
Feb 7, 2025
Merged
feat: add set account identifier function #542
MegaRedHand
merged 11 commits into
Layr-Labs:dev
from
lambdaclass:feat/add-set-account-identifier-function
Feb 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
…istry/subscriber` (Layr-Labs#533) Co-authored-by: Pablo Deymonnaz <deymonnaz@gmail.com>
MegaRedHand
reviewed
Feb 7, 2025
Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
MegaRedHand
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
This PR adds SetAccountIdentifier function implementation, and also a test case modifying the state and asserting on that change.
Also aims to fix partially issue #518
Reviewer Checklist