Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add set churn approver function #538

Merged
merged 6 commits into from
Feb 7, 2025
Merged

feat: add set churn approver function #538

merged 6 commits into from
Feb 7, 2025

Conversation

maximopalopoli
Copy link
Contributor

@maximopalopoli maximopalopoli commented Feb 7, 2025 •
edited
Loading

What Changed?

This PR adds SetChurnApprover function implementation, and a test case changing ChurnApprover's value and verifying it has changed.

Also aims to fix partially issue #518

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@maximopalopoli maximopalopoli marked this pull request as ready for review February 7, 2025 15:44
MegaRedHand
MegaRedHand approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MegaRedHand MegaRedHand added this pull request to the merge queue Feb 7, 2025
Merged via the queue into Layr-Labs:dev with commit 81c3cd3 Feb 7, 2025
9 checks passed
@MegaRedHand MegaRedHand deleted the feat/add-set-churn-approver branch February 7, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MegaRedHand MegaRedHand MegaRedHand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximopalopoli @MegaRedHand