Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate Rewards V2.1 #534

Merged
merged 13 commits into from
Feb 7, 2025
Merged

feat: integrate Rewards V2.1 #534

merged 13 commits into from
Feb 7, 2025

Conversation

Sidu28
Copy link
Contributor

@Sidu28 Sidu28 commented Feb 6, 2025

Fixes # .

What Changed?

Adds functions GetOperatorSetSplit and SetOperatorSetSplit to chainio reader and writer respectively

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@Sidu28 Sidu28 changed the title Integrate Rewards V2.1 feat: integrate Rewards V2.1 Feb 7, 2025
@Sidu28 Sidu28 requested a review from MegaRedHand February 7, 2025 01:22
@Sidu28
Copy link
Contributor Author

Sidu28 commented Feb 7, 2025

@MegaRedHand trying to figure out why the TestSetOperatorSetSplit isn't working. Essentially, it seems like the SetOperatorSetSplit() isn't doing anything, it simply returns the existing split value. I'm trying many things, but unclear as to why it isn't working

Edit: figured it out!

@Sidu28 Sidu28 marked this pull request as ready for review February 7, 2025 14:05
MegaRedHand
MegaRedHand previously approved these changes Feb 7, 2025
Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

chainio/clients/elcontracts/writer_test.go Outdated Show resolved Hide resolved
@MegaRedHand MegaRedHand enabled auto-merge February 7, 2025 15:22
@MegaRedHand MegaRedHand added this pull request to the merge queue Feb 7, 2025
Merged via the queue into dev with commit afbaa41 Feb 7, 2025
11 checks passed
@MegaRedHand MegaRedHand deleted the rewardsv2.1 branch February 7, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants