-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: elcontracts/reader
interface
#465
Closed
damiramirez
wants to merge
45
commits into
Layr-Labs:dev
from
lambdaclass:refactor/elcontracts-interface
Closed
Changes from 44 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
72e66f9
Create isOperatorRegister struct for request and response
damiramirez 21ad608
Add request-response patter to IsOperatorRegistered method
damiramirez a8ee343
Fix IsOperatorRegistered tests
damiramirez 4918141
Use utils.WrapError for error handling
damiramirez 60be609
implement request-response pattern for GetStakerShares and update tests
damiramirez eec893e
implement request-response pattern for GetDelegatedOperator and updat…
damiramirez 2cc52be
implement request-response pattern for GetOperatorDetails and update …
damiramirez 5e53962
implement request-response pattern for GetStrategyAndUnderlyingToken …
damiramirez 52d17ee
implement request-response pattern for GetStrategyAndUnderlyingERC20T…
damiramirez b4f282b
implement request-response pattern for GetOperatorSharesInStrategy an…
damiramirez 3f1792f
implement request-response pattern for CalculateDelegationApprovalDig…
damiramirez 4f9976d
implement request-response pattern for CalculateOperatorAVSRegistrati…
damiramirez 74dbe7c
implement request-response pattern for GetDistributionRootsLength and…
damiramirez 9d9ec58
implement request-response pattern for CurrRewardsCalculationEndTimes…
damiramirez 3d04f7c
implement request-response pattern for GetCurrentClaimableDistributio…
damiramirez 7594af9
implement request-response pattern for GetRootIndexFromHash and updat…
damiramirez 715aff8
implement request-response pattern for GetCumulativeClaimed and updat…
damiramirez b7ff4aa
implement request-response pattern for CheckClaim and update tests.
damiramirez c837f9e
implement request-response pattern for GetOperatorPISplit and update …
damiramirez 1920e08
implement request-response pattern for GetMaxMagnitudes and update te…
damiramirez 49d8c00
implement request-response pattern for GetAllocationInfo and update t…
damiramirez 66bf8ba
implement request-response pattern for GetOperatorShares and update t…
damiramirez 11847de
implement request-response pattern for GetOperatorsShares and update …
damiramirez 5fbcb48
implement request-response pattern for GetNumOperatorSetsForOperator …
damiramirez 2a65d15
implement request-response pattern for GetOperatorSetsForOperator and…
damiramirez 3fda235
implement request-response pattern for GetOperatorsForOperatorSet and…
damiramirez 47a6e96
implement request-response pattern for GetStrategiesForOperatorSet an…
damiramirez 6c6c782
implement request-response pattern for GetSlashableShares and update …
damiramirez d4e4f64
implement request-response pattern for GetOperatorAVSSplit and update…
damiramirez 585d9f8
implement request-response pattern for GetAllocatableMagnitude and up…
damiramirez 099139b
implement request-response pattern for GetSlashableSharesForOperatorS…
damiramirez 61cd854
implement request-response pattern for GetAllocationDelay and update …
damiramirez 8a29fa3
implement request-response pattern for GetRegisteredSets and update t…
damiramirez 1e572cd
implement request-response pattern for CanCall and update tests.
damiramirez e4b482f
implement request-response pattern for ListAppointees and update tests.
damiramirez 65b7056
implement request-response pattern for ListAppointeePermissions and u…
damiramirez b0818df
implement request-response pattern for ListPendingAdmins and update t…
damiramirez b01efd5
implement request-response pattern for ListAdmins and update tests.
damiramirez f2e0e63
implement request-response pattern for IsPendingAdmin and update tests.
damiramirez bf88f74
implement request-response pattern for IsAdmin and update tests.
damiramirez 9ecea8d
remove blockNumber of the params and move to request struct
damiramirez 4151730
Rename structs
damiramirez fe7c703
Fix typo
damiramirez ff22070
Add godocs to readers methods
damiramirez d110c54
Remove unnecessary TODO comments
damiramirez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question, should this line be left in? Or is the chainReader refactoring not finished yet? The same in the other call to
elcontracts.CalculateOperatorAVSRegistrationDigestHashRequest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same in the TODO of elcontracts's ChainWriter related to this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added that comment because the
avsregistry
andelcontracts/writer
refactors are being handled in separate PRs. It might be unnecessary to keep this comment since conflicts are expected during merging and will need to be handled regardless. So I will remove the comments!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done d110c54!