Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: elcontracts/reader interface #465

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
72e66f9
Create isOperatorRegister struct for request and response
damiramirez Jan 23, 2025
21ad608
Add request-response patter to IsOperatorRegistered method
damiramirez Jan 23, 2025
a8ee343
Fix IsOperatorRegistered tests
damiramirez Jan 23, 2025
4918141
Use utils.WrapError for error handling
damiramirez Jan 23, 2025
60be609
implement request-response pattern for GetStakerShares and update tests
damiramirez Jan 23, 2025
eec893e
implement request-response pattern for GetDelegatedOperator and updat…
damiramirez Jan 23, 2025
2cc52be
implement request-response pattern for GetOperatorDetails and update …
damiramirez Jan 23, 2025
5e53962
implement request-response pattern for GetStrategyAndUnderlyingToken …
damiramirez Jan 23, 2025
52d17ee
implement request-response pattern for GetStrategyAndUnderlyingERC20T…
damiramirez Jan 23, 2025
b4f282b
implement request-response pattern for GetOperatorSharesInStrategy an…
damiramirez Jan 23, 2025
3f1792f
implement request-response pattern for CalculateDelegationApprovalDig…
damiramirez Jan 23, 2025
4f9976d
implement request-response pattern for CalculateOperatorAVSRegistrati…
damiramirez Jan 23, 2025
74dbe7c
implement request-response pattern for GetDistributionRootsLength and…
damiramirez Jan 23, 2025
9d9ec58
implement request-response pattern for CurrRewardsCalculationEndTimes…
damiramirez Jan 23, 2025
3d04f7c
implement request-response pattern for GetCurrentClaimableDistributio…
damiramirez Jan 23, 2025
7594af9
implement request-response pattern for GetRootIndexFromHash and updat…
damiramirez Jan 23, 2025
715aff8
implement request-response pattern for GetCumulativeClaimed and updat…
damiramirez Jan 23, 2025
b7ff4aa
implement request-response pattern for CheckClaim and update tests.
damiramirez Jan 23, 2025
c837f9e
implement request-response pattern for GetOperatorPISplit and update …
damiramirez Jan 23, 2025
1920e08
implement request-response pattern for GetMaxMagnitudes and update te…
damiramirez Jan 23, 2025
49d8c00
implement request-response pattern for GetAllocationInfo and update t…
damiramirez Jan 23, 2025
66bf8ba
implement request-response pattern for GetOperatorShares and update t…
damiramirez Jan 23, 2025
11847de
implement request-response pattern for GetOperatorsShares and update …
damiramirez Jan 23, 2025
5fbcb48
implement request-response pattern for GetNumOperatorSetsForOperator …
damiramirez Jan 23, 2025
2a65d15
implement request-response pattern for GetOperatorSetsForOperator and…
damiramirez Jan 23, 2025
3fda235
implement request-response pattern for GetOperatorsForOperatorSet and…
damiramirez Jan 23, 2025
47a6e96
implement request-response pattern for GetStrategiesForOperatorSet an…
damiramirez Jan 23, 2025
6c6c782
implement request-response pattern for GetSlashableShares and update …
damiramirez Jan 23, 2025
d4e4f64
implement request-response pattern for GetOperatorAVSSplit and update…
damiramirez Jan 24, 2025
585d9f8
implement request-response pattern for GetAllocatableMagnitude and up…
damiramirez Jan 24, 2025
099139b
implement request-response pattern for GetSlashableSharesForOperatorS…
damiramirez Jan 24, 2025
61cd854
implement request-response pattern for GetAllocationDelay and update …
damiramirez Jan 24, 2025
8a29fa3
implement request-response pattern for GetRegisteredSets and update t…
damiramirez Jan 24, 2025
1e572cd
implement request-response pattern for CanCall and update tests.
damiramirez Jan 24, 2025
e4b482f
implement request-response pattern for ListAppointees and update tests.
damiramirez Jan 24, 2025
65b7056
implement request-response pattern for ListAppointeePermissions and u…
damiramirez Jan 24, 2025
b0818df
implement request-response pattern for ListPendingAdmins and update t…
damiramirez Jan 24, 2025
b01efd5
implement request-response pattern for ListAdmins and update tests.
damiramirez Jan 24, 2025
f2e0e63
implement request-response pattern for IsPendingAdmin and update tests.
damiramirez Jan 24, 2025
bf88f74
implement request-response pattern for IsAdmin and update tests.
damiramirez Jan 24, 2025
9ecea8d
remove blockNumber of the params and move to request struct
damiramirez Jan 24, 2025
4151730
Rename structs
damiramirez Jan 24, 2025
fe7c703
Fix typo
damiramirez Jan 24, 2025
ff22070
Add godocs to readers methods
damiramirez Jan 24, 2025
d110c54
Remove unnecessary TODO comments
damiramirez Jan 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 20 additions & 17 deletions chainio/clients/avsregistry/writer.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,8 @@ import (
type eLReader interface {
CalculateOperatorAVSRegistrationDigestHash(
ctx context.Context,
operatorAddr gethcommon.Address,
serviceManagerAddr gethcommon.Address,
operatorToAvsRegistrationSigSalt [32]byte,
operatorToAvsRegistrationSigExpiry *big.Int,
) ([32]byte, error)
request elcontracts.CalculateOperatorAVSRegistrationDigestHashRequest,
) (elcontracts.CalculateOperatorAVSRegistrationDigestHashResponse, error)
}

type ChainWriter struct {
Expand Down Expand Up @@ -161,17 +158,20 @@ func (w *ChainWriter) RegisterOperatorInQuorumWithAVSRegistryCoordinator(
}

// params to register operator in delegation manager's operator-avs mapping
msgToSign, err := w.elReader.CalculateOperatorAVSRegistrationDigestHash(
request := elcontracts.CalculateOperatorAVSRegistrationDigestHashRequest{
OperatorAddress: operatorAddr,
AVSAddress: w.serviceManagerAddr,
Salt: operatorToAvsRegistrationSigSalt,
Expiry: operatorToAvsRegistrationSigExpiry,
}
response, err := w.elReader.CalculateOperatorAVSRegistrationDigestHash(
ctx,
operatorAddr,
w.serviceManagerAddr,
operatorToAvsRegistrationSigSalt,
operatorToAvsRegistrationSigExpiry,
request,
)
if err != nil {
return nil, err
}
operatorSignature, err := crypto.Sign(msgToSign[:], operatorEcdsaPrivateKey)
operatorSignature, err := crypto.Sign(response.DigestHash[:], operatorEcdsaPrivateKey)
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -283,17 +283,20 @@ func (w *ChainWriter) RegisterOperator(
).Add(new(big.Int).SetUint64(curBlock.Time()), big.NewInt(sigValidForSeconds))

// params to register operator in delegation manager's operator-avs mapping
msgToSign, err := w.elReader.CalculateOperatorAVSRegistrationDigestHash(
request := elcontracts.CalculateOperatorAVSRegistrationDigestHashRequest{
OperatorAddress: operatorAddr,
AVSAddress: w.serviceManagerAddr,
Salt: operatorToAvsRegistrationSigSalt,
Expiry: operatorToAvsRegistrationSigExpiry,
}
response, err := w.elReader.CalculateOperatorAVSRegistrationDigestHash(
ctx,
operatorAddr,
w.serviceManagerAddr,
operatorToAvsRegistrationSigSalt,
operatorToAvsRegistrationSigExpiry,
request,
)
if err != nil {
return nil, err
}
operatorSignature, err := crypto.Sign(msgToSign[:], operatorEcdsaPrivateKey)
operatorSignature, err := crypto.Sign(response.DigestHash[:], operatorEcdsaPrivateKey)
if err != nil {
return nil, err
}
Expand Down
Loading