Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: chainWriter add edge case tests to improve coverage #451

Merged
merged 13 commits into from
Jan 20, 2025
Merged

test: chainWriter add edge case tests to improve coverage #451

merged 13 commits into from
Jan 20, 2025

Conversation

damiramirez
Copy link
Contributor

@damiramirez damiramirez commented Jan 20, 2025 •
edited
Loading

What Changed?

This PR aims to improve the test coverage for chainWriter by including tests for edge cases scenarios.

I also rearranged the functions getPubkeyRegistrationParams and abiEncodeRegistrationParams in writer.go so that the public functions appear first, followed by the private functions. Applied the same for newTestClaim in writer_test.go.

Added ANVIL_THIRD_ADDRESS and ANVIL_THIRD_PRIVATE_KEY constant in anvil.go.

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@damiramirez damiramirez marked this pull request as ready for review January 20, 2025 19:12
@damiramirez damiramirez changed the title test: add edge case tests to improve coverage chainWriter test: chainWriter add edge case tests to improve coverage Jan 20, 2025
@pablodeymo pablodeymo added this pull request to the merge queue Jan 20, 2025
Merged via the queue into Layr-Labs:dev with commit d7cd838 Jan 20, 2025
4 checks passed
@pablodeymo pablodeymo deleted the test/elcontract-write branch January 20, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablodeymo pablodeymo pablodeymo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damiramirez @pablodeymo