test: add test cases where contract returns an error #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
The initial idea was to test the cases in which the binding response returned an error. I was able to do it only in two cases, in the others, since the chain reader is mainly a getter, it was difficult to get it to return an error. Makes test coverage of
chainio/clients/elcontracts/reader.goincrease in 1%.Also in this PR some verifications on binding result are removed, since they only added a little description on the returned error, but the error was extended anyway. The verification removed were those that didn't add context to the error, and those that added context, like those calling permissionController contract were not removed.
Reviewer Checklist