-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{WIP} Test elcontracts slashing functions #416
Draft
pablodeymo
wants to merge
21
commits into
dev
Choose a base branch
from
test_elcontracts_slashing_functions
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+210
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make improve init address comments address comments slashing push working slashing update contracts submodules update to new AM fix test update to remove slasher and into AM feat: add new funcs (#382) Co-authored-by: Madhur Shrimal <madhur.shrimal@gmail.com> update contracts submodules update contracts submodules update with latest methods rebase update to ctx change name address comments more methods rebase and new changes fix reader tests fix reader tests fmt Updating core bindings and adding UserCanCall for UAM. Adding PermissionController binding to binding constructors. Adding list users and list permissions APIs to EL reader. fix: anvil setup (#400) Updating bindings and adding appointee remove & set implementations. Fixing import ordering and returning tx receipt for appointee mutations. Adding IsPendingAdmin & IsAdmin read APIs. Adding admin mutation request types and APIs to writer implementation. Updating based on make fmt results. Updating user naming to appointee.
make improve init address comments address comments slashing push working slashing update contracts submodules update to new AM fix test update to remove slasher and into AM feat: add new funcs (#382) Co-authored-by: Madhur Shrimal <madhur.shrimal@gmail.com> update contracts submodules update contracts submodules update with latest methods rebase update to ctx change name address comments more methods rebase and new changes fix reader tests fix reader tests fmt Updating core bindings and adding UserCanCall for UAM. Adding PermissionController binding to binding constructors. Adding list users and list permissions APIs to EL reader. fix: anvil setup (#400) Updating bindings and adding appointee remove & set implementations. Fixing import ordering and returning tx receipt for appointee mutations. Adding IsPendingAdmin & IsAdmin read APIs. Adding admin mutation request types and APIs to writer implementation. Updating based on make fmt results. Updating user naming to appointee. fmt Adding factory methods to create unsigned transactions from the EL writer. chore: update the core contract deps (#409) add slashable shares (#410) Parameterizing txOpts for injection for noOpt cases. chore: remove staker_opt_out_window_blocks (#412) Fixing lint errors for AddPendingAdmin on EL Writer. Updating appointee set & remove methods to support injecting txOpts.
shrimalmadhur
force-pushed
the
madhur/tmp-slashing
branch
from
January 2, 2025 18:26
1dd4a5c
to
2e1a034
Compare
make improve init address comments address comments slashing push working slashing update contracts submodules update to new AM fix test update to remove slasher and into AM feat: add new funcs (#382) Co-authored-by: Madhur Shrimal <madhur.shrimal@gmail.com> update contracts submodules update contracts submodules update with latest methods rebase update to ctx change name address comments more methods rebase and new changes fix reader tests fix reader tests fmt Updating core bindings and adding UserCanCall for UAM. Adding PermissionController binding to binding constructors. Adding list users and list permissions APIs to EL reader. fix: anvil setup (#400) Updating bindings and adding appointee remove & set implementations. Fixing import ordering and returning tx receipt for appointee mutations. Adding IsPendingAdmin & IsAdmin read APIs. Adding admin mutation request types and APIs to writer implementation. Updating based on make fmt results. Updating user naming to appointee. fmt Adding factory methods to create unsigned transactions from the EL writer. chore: update the core contract deps (#409) add slashable shares (#410) Parameterizing txOpts for injection for noOpt cases. chore: remove staker_opt_out_window_blocks (#412) Fixing lint errors for AddPendingAdmin on EL Writer. Updating appointee set & remove methods to support injecting txOpts.
shrimalmadhur
force-pushed
the
madhur/tmp-slashing
branch
from
January 2, 2025 20:25
9dcca30
to
1092cba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
What Changed?
Reviewer Checklist