fix: change literal string values for constants or predefined values (#…

…442)

chainio/clients/avsregistry/writer_test.go

@@ -6,6 +6,7 @@ import (
 
 	chainioutils "github.com/Layr-Labs/eigensdk-go/chainio/utils"
 	"github.com/Layr-Labs/eigensdk-go/crypto/bls"
+	"github.com/Layr-Labs/eigensdk-go/testutils"
 	"github.com/Layr-Labs/eigensdk-go/testutils/testclients"
 	"github.com/Layr-Labs/eigensdk-go/types"
 	gethcommon "github.com/ethereum/go-ethereum/common"
@@ -20,9 +21,8 @@ func TestWriterMethods(t *testing.T) {
 	keypair, err := bls.NewKeyPairFromString("0x01")
 	require.NoError(t, err)
 
-	addr := gethcommon.HexToAddress("0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266")
-	ecdsaPrivKeyHex := "ac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80"
-	ecdsaPrivateKey, err := crypto.HexToECDSA(ecdsaPrivKeyHex)
+	addr := gethcommon.HexToAddress(testutils.ANVIL_FIRST_ADDRESS)
+	ecdsaPrivateKey, err := crypto.HexToECDSA(testutils.ANVIL_FIRST_PRIVATE_KEY)
 	require.NoError(t, err)
 
 	quorumNumbers := types.QuorumNums{0}

chainio/clients/elcontracts/reader_test.go

@@ -25,7 +25,7 @@ func TestChainReader(t *testing.T) {
 
 	contractAddrs := testutils.GetContractAddressesFromContractRegistry(anvilHttpEndpoint)
 	operator := types.Operator{
-		Address: "0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266",
+		Address: testutils.ANVIL_FIRST_ADDRESS,
 	}
 
 	t.Run("is operator registered", func(t *testing.T) {

chainio/clients/elcontracts/writer_test.go

@@ -187,8 +187,7 @@ func TestSetClaimerFor(t *testing.T) {
 	require.NoError(t, err)
 
 	waitForReceipt := true
-	claimer := common.HexToAddress("0x2279B7A0a67DB372996a5FaB50D91eAA73d2eBe6")
-
+	claimer := contractAddrs.RewardsCoordinator
 	// call SetClaimerFor
 	receipt, err := chainWriter.SetClaimerFor(context.Background(), claimer, waitForReceipt)
 	require.NoError(t, err)

chainio/clients/eth/instrumented_client_test.go

@@ -362,8 +362,7 @@ func TestTransactionMethods(t *testing.T) {
 		Gas:   21000,
 	})
 
-	ecdsaPrivKeyHex := "ac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80"
-	ecdsaPrivKey, err := crypto.HexToECDSA(ecdsaPrivKeyHex)
+	ecdsaPrivKey, err := crypto.HexToECDSA(testutils.ANVIL_FIRST_PRIVATE_KEY)
 	assert.NoError(t, err)
 	signer := types.LatestSignerForChainID(big.NewInt(31337))
 	signature, err := crypto.Sign(signer.Hash(tx).Bytes(), ecdsaPrivKey)

chainio/clients/wallet/privatekey_wallet_test.go

@@ -31,8 +31,7 @@ func TestPrivateKeyWallet(t *testing.T) {
 		ethClient, err := ethclient.Dial(anvilHttpEndpoint)
 		require.NoError(t, err)
 
-		ecdsaPrivKeyHex := "ac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80"
-		ecdsaPrivKey, err := crypto.HexToECDSA(ecdsaPrivKeyHex)
+		ecdsaPrivKey, err := crypto.HexToECDSA(testutils.ANVIL_FIRST_PRIVATE_KEY)
 		require.NoError(t, err)
 		signerV2, signerAddr, err := signerv2.SignerFromConfig(signerv2.Config{PrivateKey: ecdsaPrivKey}, chainId)
 		if err != nil {

chainio/txmgr/geometric/geometric_example_test.go

@@ -33,7 +33,7 @@ func ExampleGeometricTxManager() {
 		panic(err)
 	}
 
-	ecdsaPrivateKey, err := crypto.HexToECDSA("ac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80")
+	ecdsaPrivateKey, err := crypto.HexToECDSA(testutils.ANVIL_FIRST_PRIVATE_KEY)
 	if err != nil {
 		panic(err)
 	}

chainio/txmgr/geometric/geometric_test.go

@@ -377,7 +377,7 @@ func newIntegrationTestHarness(t *testing.T) *integrationTestHarness {
 	require.NoError(t, err)
 
 	ecdsaSk, ecdsaAddr, err := ecdsa.KeyAndAddressFromHexKey(
-		"0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80",
+		testutils.ANVIL_FIRST_PRIVATE_KEY,
 	)
 	require.NoError(t, err)
 

services/bls_aggregation/blsagg_test.go

@@ -1644,8 +1644,7 @@ func TestIntegrationBlsAgg(t *testing.T) {
 		testData := testutils.NewTestData(defaultInput)
 
 		// define operator ecdsa and bls private keys
-		ecdsaPrivKeyHex := "ac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80"
-		ecdsaPrivKey, err := crypto.HexToECDSA(ecdsaPrivKeyHex)
+		ecdsaPrivKey, err := crypto.HexToECDSA(testutils.ANVIL_FIRST_PRIVATE_KEY)
 		require.NoError(t, err)
 		blsPrivKeyHex := testData.Input.BlsPrivKey
 		blsKeyPair := newBlsKeyPairPanics(blsPrivKeyHex)

signerv2/signer_test.go

@@ -14,8 +14,7 @@ import (
 )
 
 func TestPrivateKeySignerFn(t *testing.T) {
-	privateKeyHex := "ac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80"
-	privateKey, err := crypto.HexToECDSA(privateKeyHex)
+	privateKey, err := crypto.HexToECDSA(testutils.ANVIL_FIRST_PRIVATE_KEY)
 	require.NoError(t, err)
 	chainID := big.NewInt(1)
 
@@ -74,7 +73,7 @@ func TestWeb3SignerFn(t *testing.T) {
 	signer, err := signerv2.Web3SignerFn(anvilHttpEndpoint)
 	require.NoError(t, err)
 
-	privateKey, err := crypto.HexToECDSA("ac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80")
+	privateKey, err := crypto.HexToECDSA(testutils.ANVIL_FIRST_PRIVATE_KEY)
 	require.NoError(t, err)
 	anvilChainID := big.NewInt(31337)
 	address := crypto.PubkeyToAddress(privateKey.PublicKey)

testutils/anvil.go

@@ -20,7 +20,7 @@ import (
 )
 
 const (
-	ANVIL_FIRST_ADDRESS      = "f39Fd6e51aad88F6F4ce6aB8827279cffFb92266"
+	ANVIL_FIRST_ADDRESS      = "0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266"
 	ANVIL_FIRST_PRIVATE_KEY  = "ac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80"
 	ANVIL_SECOND_ADDRESS     = "70997970C51812dc3A010C7d01b50e0d17dc79C8"
 	ANVIL_SECOND_PRIVATE_KEY = "59c6995e998f97a5a0044966f0945389dc9e86dae88c7a8412f4603b6b78690d"

testutils/testclients/testclients.go

@@ -33,7 +33,7 @@ func BuildTestClients(t *testing.T) (*clients.Clients, string) {
 	require.NoError(t, err)
 	logger := logging.NewTextSLogger(os.Stdout, &logging.SLoggerOptions{Level: testConfig.LogLevel})
 
-	privateKeyHex := "ac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80"
+	privateKeyHex := testutils.ANVIL_FIRST_PRIVATE_KEY
 	ecdsaPrivateKey, err := crypto.HexToECDSA(privateKeyHex)
 	require.NoError(t, err)