feat: fixed accounting bug and refactoring #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shotaronowhere
merged commit 3dd31a5
into
feat-stakeroot-cleanup
12 of 16 checks passed
shotaronowhere
added a commit
that referenced
this pull request
Sep 19, 2024
shotaronowhere
added a commit
that referenced
this pull request
Sep 19, 2024
* chore: forge fmt src/contracts * nit: organize imports * fix: bump pragma -> ^0.8.27 * refactor(optimization): significantly reduce sloads/sstores * refactor: custom errors * refactor(optimization): significantly reduce sloads/sstores missed some stuff * refactor: rename compendium -> manager * refactor: more storage optmizations * feat: safe eth transfer helper * refactor: manager -> compendium * refactor: variable renaming * refactor: rename compendium -> manager * feat: add `proofIntervalSeconds` getter * feat: fixed accounting bug and refactoring (#767) * refactor: review reconciliations * refactor: review reconciliations * fix: rename colluding param * fix: types and naming * fix: revert stakeroot calculation changes * fix: revert stakeRoot calc views --------- Co-authored-by: shotaro <10378902+shotaronowhere@users.noreply.github.com>
gpsanant
pushed a commit
that referenced
this pull request
Sep 20, 2024
* chore: forge fmt src/contracts * nit: organize imports * fix: bump pragma -> ^0.8.27 * refactor(optimization): significantly reduce sloads/sstores * refactor: custom errors * refactor(optimization): significantly reduce sloads/sstores missed some stuff * refactor: rename compendium -> manager * refactor: more storage optmizations * feat: safe eth transfer helper * refactor: manager -> compendium * refactor: variable renaming * refactor: rename compendium -> manager * feat: add `proofIntervalSeconds` getter * feat: fixed accounting bug and refactoring (#767) * refactor: review reconciliations * refactor: review reconciliations * fix: rename colluding param * fix: types and naming * fix: revert stakeroot calculation changes * fix: revert stakeRoot calc views --------- Co-authored-by: shotaro <10378902+shotaronowhere@users.noreply.github.com>
gpsanant
pushed a commit
that referenced
this pull request
Sep 21, 2024
* chore: forge fmt src/contracts * nit: organize imports * fix: bump pragma -> ^0.8.27 * refactor(optimization): significantly reduce sloads/sstores * refactor: custom errors * refactor(optimization): significantly reduce sloads/sstores missed some stuff * refactor: rename compendium -> manager * refactor: more storage optmizations * feat: safe eth transfer helper * refactor: manager -> compendium * refactor: variable renaming * refactor: rename compendium -> manager * feat: add `proofIntervalSeconds` getter * feat: fixed accounting bug and refactoring (#767) * refactor: review reconciliations * refactor: review reconciliations * fix: rename colluding param * fix: types and naming * fix: revert stakeroot calculation changes * fix: revert stakeRoot calc views --------- Co-authored-by: shotaro <10378902+shotaronowhere@users.noreply.github.com>
ypatil12
pushed a commit
that referenced
this pull request
Sep 24, 2024
* chore: forge fmt src/contracts * nit: organize imports * fix: bump pragma -> ^0.8.27 * refactor(optimization): significantly reduce sloads/sstores * refactor: custom errors * refactor(optimization): significantly reduce sloads/sstores missed some stuff * refactor: rename compendium -> manager * refactor: more storage optmizations * feat: safe eth transfer helper * refactor: manager -> compendium * refactor: variable renaming * refactor: rename compendium -> manager * feat: add `proofIntervalSeconds` getter * feat: fixed accounting bug and refactoring (#767) * refactor: review reconciliations * refactor: review reconciliations * fix: rename colluding param * fix: types and naming * fix: revert stakeroot calculation changes * fix: revert stakeRoot calc views --------- Co-authored-by: shotaro <10378902+shotaronowhere@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an accounting bug when updating params this is fixed.
I'm comfortable with the refactor in #766 , so i'm building off of that and just keeping this branch separate until there's another review. If we toss out the #766 refactor I can migrate the fix.
totalChargetochargePerProof