Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add bls signer abstraction from eigensdk #985

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

add bls signer abstraction from eigensdk #985

wants to merge 2 commits into from

Conversation

shrimalmadhur
Copy link
Contributor

@shrimalmadhur shrimalmadhur commented Dec 11, 2024 •
edited
Loading

Why are these changes needed?

  • Ignore the logger changes as eigensdk removed the logger so I have defined a logging util in testutils

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@shrimalmadhur shrimalmadhur force-pushed the madhur/eigensdk-bls-abstraction-update branch 2 times, most recently from abb4631 to 1c92ed0 Compare December 19, 2024 22:07
@shrimalmadhur shrimalmadhur force-pushed the madhur/eigensdk-bls-abstraction-update branch 2 times, most recently from 6bd9746 to 5af9a4b Compare January 8, 2025 23:08
@shrimalmadhur
add bls signer abstraction from eigensdk
7c7c900 
update eigensdk to that commit

upgrade logger to remove noop

fix testmode

fix nil pointers

rebase and fix

rebase

update to new eigensdk

add bls signer to plugin

fix unit tests

fix g2 point deser

fix file

signer

fix copying

remove unused code
@shrimalmadhur shrimalmadhur force-pushed the madhur/eigensdk-bls-abstraction-update branch from 2abf113 to 7c7c900 Compare January 11, 2025 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shrimalmadhur