Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition when rebuilding proto files. #813

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

cody-littley
Copy link
Contributor

Why are these changes needed?

There was an odd race condition that would cause make protoc to fail if run multiple times in a row. I think it had something to do with asynchronous file system operations. I didn't totally understand the problem, but deleting the protobuf directories when cleaning make the issue go away.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • hand tests
    • Unit tests
    • Integration tests
    • This PR is not tested :(

Signed-off-by: Cody Littley <cody@eigenlabs.org>
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley cody-littley requested a review from ian-shim October 16, 2024 19:52
@cody-littley cody-littley self-assigned this Oct 16, 2024
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley cody-littley merged commit 0ee84f9 into Layr-Labs:master Oct 17, 2024
7 checks passed
@cody-littley cody-littley deleted the fix-proto-build-race branch October 17, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants