Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(contracts): Add binding check #1217

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ethenotethan
Copy link
Contributor

@ethenotethan ethenotethan commented Feb 5, 2025

Why are these changes needed?

Adds a hygiene workflow which ensures that abi artifacts must be reflective of latest contract changes. Also noticed we were using two compilation commands (compile-el, compile-dl); these don't appear to have any instrumentation over the compile.sh script behavior so condensed into single compile-contracts target 😄

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@@ -37,3 +37,31 @@ jobs:
- name: Run snapshot
run: forge snapshot
working-directory: ./contracts

binding-verify:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this run in CI then?

If so, why have the bindings committed to the repo at all, if we generate them in CI?

@jianoaix
Copy link
Contributor

jianoaix commented Feb 5, 2025

The PR lgtm, but i think we had some discussion before regarding if requiring the latest version of binding, if anyone remembers it, may bring the context here so we make sure this is what we decided to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants